Skip to content

Update for AMD CI workflow #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrwyattii merged 12 commits into from
Aug 3, 2022
+7 −4
Merged

Update for AMD CI workflow #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aa423a2
use torch-provided rocm in AMD runner
mrwyattii Aug 2, 2022
2118047
Merge branch 'master' into update-amd-workflow
mrwyattii Aug 2, 2022
88e0486
fix for module level pytest skip
mrwyattii Aug 2, 2022
55c9ac7
restrict which tests are run
mrwyattii Aug 2, 2022
5ff4ce6
test fix for AMD
mrwyattii Aug 2, 2022
d0494b5
testing fix for cuda init errors
mrwyattii Aug 3, 2022
9b15311
test if DistTest will fix the error
mrwyattii Aug 3, 2022
168a3e6
remove --forked from pytest
mrwyattii Aug 3, 2022
d30be54
Merge branch 'master' into update-amd-workflow
mrwyattii Aug 3, 2022
8c8b37b
Update test_cpu_adagrad.py
mrwyattii Aug 3, 2022
a3a73ad
Update amd.yml
mrwyattii Aug 3, 2022
9065f1d
Update common.py
mrwyattii Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/amd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ jobs:
python --version
which hipcc
hipcc --version
pip install --upgrade pip
pip uninstall --yes torch torchvision
pip install torch torchvision --extra-index-url https://download.pytorch.org/whl/rocm5.1.1
python -c "import torch; print('torch:', torch.__version__, torch)"
python -c "import torch; print('CUDA available:', torch.cuda.is_available())"
sudo apt-get update
Expand Down Expand Up @@ -63,5 +66,5 @@ jobs:
run: |
if [[ -d ./torch-extensions ]]; then rm -rf ./torch-extensions; fi
cd tests
TORCH_EXTENSIONS_DIR=./torch-extensions pytest --color=yes --durations=0 --forked --verbose -x -n 4 unit/
TORCH_EXTENSIONS_DIR=./torch-extensions pytest --color=yes --durations=0 --forked --verbose -x -m 'sequential' unit/
TORCH_EXTENSIONS_DIR=./torch-extensions pytest --color=yes --durations=0 --verbose -n 4 unit/{comm,inference,monitor,ops,profiling,runtime}
#TORCH_EXTENSIONS_DIR=./torch-extensions pytest --color=yes --durations=0 --verbose -m 'sequential' unit/{comm,inference,monitor,ops,profiling,runtime}
2 changes: 1 addition & 1 deletion tests/unit/ops/adagrad/test_cpu_adagrad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from deepspeed.ops.op_builder import CPUAdagradBuilder

if not deepspeed.ops.__compatible_ops__[CPUAdagradBuilder.NAME]:
pytest.skip("cpu-adagrad is not compatible")
pytest.skip("cpu-adagrad is not compatible", allow_module_level=True)


def check_equal(first, second, atol=1e-2, verbose=False):
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/ops/adam/test_cpu_adam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from deepspeed.ops.op_builder import CPUAdamBuilder

if not deepspeed.ops.__compatible_ops__[CPUAdamBuilder.NAME]:
pytest.skip("cpu-adam is not compatible")
pytest.skip("cpu-adam is not compatible", allow_module_level=True)

pytest.cpu_vendor = get_cpu_info()["vendor_id_raw"].lower()

Expand Down