Skip to content

[ROCm] Wrong command broke ROCm build. #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrwyattii merged 2 commits into from
Jul 25, 2022
Merged

[ROCm] Wrong command broke ROCm build. #2118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc16337
[ROCm] Wrong command broke ROCm build.
jpvillam-amd Jul 20, 2022
13c83dd
Merge branch 'master' into fix-rocm-jpvillam
mrwyattii Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion op_builder/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def installed_rocm_version():
if OpBuilder.is_rocm_pytorch():
from torch.utils.cpp_extension import ROCM_HOME
rocm_ver_file = Path(ROCM_HOME).joinpath(".info/version-dev")
if rocm_ver_file.isfile():
if rocm_ver_file.is_file():
with open(rocm_ver_file, 'r') as file:
ROCM_VERSION_DEV_RAW = file.read()
elif "rocm" in roch.__version__:
Expand Down