Skip to content

Remove hardcoded ROCm install path #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrwyattii merged 5 commits into from
Jul 19, 2022
Merged

Remove hardcoded ROCm install path #2093

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c44c8b
fix hard-coded rocm install path
mrwyattii Jul 13, 2022
6f578be
Merge branch 'master' into fix-rocm-path-find
mrwyattii Jul 18, 2022
838bfed
added fix for newest torch+rocm install
mrwyattii Jul 18, 2022
618174e
added backup for not detecting rocm at all
mrwyattii Jul 19, 2022
bbd6795
Merge branch 'master' into fix-rocm-path-find
mrwyattii Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions op_builder/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,15 @@ def installed_rocm_version():
ROCM_MINOR = '0'
if OpBuilder.is_rocm_pytorch():
from torch.utils.cpp_extension import ROCM_HOME
with open('/opt/rocm/.info/version-dev', 'r') as file:
ROCM_VERSION_DEV_RAW = file.read()
rocm_ver_file = Path(ROCM_HOME).joinpath(".info/version-dev")
if rocm_ver_file.isfile():
with open(rocm_ver_file, 'r') as file:
ROCM_VERSION_DEV_RAW = file.read()
elif "rocm" in roch.__version__:
ROCM_VERSION_DEV_RAW = torch.__version__.split("rocm")[1]
else:
assert False, "Could not detect ROCm version"
assert ROCM_VERSION_DEV_RAW is not "", "Could not detect ROCm version"
ROCM_MAJOR = ROCM_VERSION_DEV_RAW.split('.')[0]
ROCM_MINOR = ROCM_VERSION_DEV_RAW.split('.')[1]
OpBuilder._rocm_version = (int(ROCM_MAJOR), int(ROCM_MINOR))
Expand Down