Skip to content

Fix inference unit test import error catching #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrwyattii merged 9 commits into from
Jun 21, 2022
Merged

Fix inference unit test import error catching #2024

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1def72d
fix to catch assert error for inference test imports
mrwyattii Jun 16, 2022
955666b
fix wrong syntax
mrwyattii Jun 16, 2022
c212a97
changed to sequential inf tests
mrwyattii Jun 16, 2022
9bdbb9c
fix for lm_eval import
mrwyattii Jun 16, 2022
23184ad
added environment check fixture
mrwyattii Jun 16, 2022
3443d50
added expected torch and cuda version
mrwyattii Jun 16, 2022
4a6ed83
check various version depth for cuda/torch
mrwyattii Jun 16, 2022
aa7ab41
Merge branch 'master' into pytest-inference-tests-import-fix
tjruwase Jun 16, 2022
e0be16b
Merge branch 'master' into pytest-inference-tests-import-fix
jeffra Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nv-inference.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ jobs:
unset TORCH_CUDA_ARCH_LIST # only jit compile for current arch
if [[ -d ./torch-extensions ]]; then rm -rf ./torch-extensions; fi
cd tests
TORCH_EXTENSIONS_DIR=./torch-extensions pytest --color=yes --durations=0 --forked --verbose -n 4 -m 'inference' unit/
TORCH_EXTENSIONS_DIR=./torch-extensions pytest --color=yes --durations=0 --forked --verbose -m 'inference' unit/
2 changes: 1 addition & 1 deletion tests/unit/test_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from lm_eval.evaluator import evaluate
from transformers import pipeline, AutoModelForCausalLM, AutoTokenizer
from huggingface_hub import HfApi
except ImportError:
except (ImportError, AssertionError) as e:
Comment thread
mrwyattii marked this conversation as resolved.
Outdated
pytest.skip("please install w. [inf] extra to run this test",
allow_module_level=True)

Expand Down