chore: renaming deserialize_document_store_in_init_params_inplace
#8379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
type:documentation
davidsbatista
changed the title
deserialize_document_store_in_init_params_inplaceuti, it works with any other component
Pull Request Test Coverage Report for Build 12809215757Details
💛 - Coveralls |
davidsbatista
changed the title
deserialize_document_store_in_init_params_inplaceuti, it works with any other componentdeserialize_document_store_in_init_params_inplace, it works with any other component
davidsbatista
changed the title
deserialize_document_store_in_init_params_inplace, it works with any other componentrenaming deserialize_document_store_in_init_params_inplace
davidsbatista
commented
Sep 17, 2024
releasenotes/notes/rename-deserialize-in-place-function-f92bf2e801dbd940.yaml
Outdated
Show resolved
Hide resolved
davidsbatista
requested review from
dfokina,
vblagoje and
shadeMe
and removed request for
a team
vblagoje
reviewed
Jan 16, 2025
| @@ -29,6 +29,6 @@ | |||
| "deserialize_callable", | |||
| "serialize_type", | |||
| "deserialize_type", | |||
| "deserialize_document_store_in_init_params_inplace", | |||
| "deserialize_component_in_init_params_inplace", | |||
There was a problem hiding this comment.
We can create an alias above from here:
deserialize_document_store_in_init_params_inplace = deserialize_component_in_init_params_inplace
and then export both to minimize havoc this will create in downstream deps
|
NOTE: this is an old PR, I just updated it to see if it has any conflicts - note 100% sure if it still make sense, also OK if we just close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
deserialize_document_store_in_init_params_inplaceutil, since it can also work with any other componentHow did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.