Skip to content

refactor: Remove api_key from serialization of AzureOCRDocumentConverter and SerperDevWebSearch #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anakin87 merged 5 commits into from
Oct 23, 2023
Merged

refactor: Remove api_key from serialization of AzureOCRDocumentConverter and SerperDevWebSearch #6150

anakin87 merged 5 commits into from
Oct 23, 2023

Conversation

@awinml
Copy link
Contributor

@awinml awinml commented Oct 22, 2023 •
edited
Loading

Related Issues

Proposed Changes:

Remove api_key from serialization of AzureOCRDocumentConverter and SerperDevWebSearch

How did you test it?

Unit Tests have been updated to test the serialization without api_key.

Notes for the reviewer

I have opened a PR (#6149) for migrating RemoteWhisperTranscriber to the OpenAI SDK. The RemoteWhisperTranscriber implementation in that PR does not serialize the api_key and is fixed as part of that PR.

Checklist

@awinml awinml requested a review from a team as a code owner October 22, 2023 21:28
@awinml awinml requested review from anakin87 and removed request for a team October 22, 2023 21:28
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Oct 22, 2023
@awinml awinml mentioned this pull request Oct 22, 2023
Closed
@awinml awinml requested a review from a team as a code owner October 22, 2023 21:39
@awinml awinml requested review from dfokina and removed request for a team October 22, 2023 21:39
anakin87
anakin87 reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another good PR!

I left a comment.
I also suggest adding a test_init_fail_wo_api_key to test_serperdev.

@anakin87
Copy link
Member

anakin87 commented Oct 23, 2023

Your PR is ready to go! 🎉

@anakin87 anakin87 self-requested a review October 23, 2023 10:25
@anakin87 anakin87 merged commit 101bd81 into deepset-ai:main Oct 23, 2023
@awinml awinml deleted the remove_api_key_serialization branch November 29, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anakin87 anakin87 anakin87 approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina was automatically assigned from deepset-ai/documentation

Assignees

No one assigned

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove api_key from serialization of AzureOCRDocumentConverter, SerperDevWebSearch, RemoteWhisperTranscriber 2.0

2 participants

@awinml @anakin87