ci: Increase Weaviate's disk usage + print docker logs #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdankostic
added
the
ignore-for-release-notes
bogdankostic
changed the title
masci
reviewed
Aug 11, 2022
| @@ -391,6 +395,10 @@ jobs: | |||
| run: | | |||
| pytest ${{ env.PYTEST_PARAMS }} -m "not integration" test/document_stores/ --document_store_type=milvus | |||
|
|
|||
| - name: Dump docker logs on failure | |||
| @@ -244,6 +244,10 @@ jobs: | |||
| run: | | |||
| pytest ${{ env.PYTEST_PARAMS }} -m "elasticsearch and not integration" test/document_stores/ --document_store_type=elasticsearch | |||
|
|
|||
| - name: Dump docker logs on failure | |||
There was a problem hiding this comment.
is this related to weaviate?
There was a problem hiding this comment.
This is not directly related to Weaviate, but to the docker containers in the CI. This will allow us to inspect the docker logs if the CI fails.
masci
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
test_retriever.py::test_dpr_embeddingfor Weaviate is flaky #3024Proposed Changes:
This PR increases the disk limit for Weaviate in the CI from the default 90% to 95%. Furthermore, it adds the
gh-docker-logsaction which will provide the Docker logs in cases where the CI fails.