Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch label variables in test_labels #3011

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

jamescalam
Copy link
Contributor

Related Issues

Proposed Changes:

Use labels variable in test_labels relies on labels being returned from the doc store in a specific order.

How did you test it?

Manual verification

Notes for the reviewer

test/document_stores/test_document_store.py

Checklist

@jamescalam jamescalam requested a review from a team as a code owner August 9, 2022 15:02
@TuanaCelik TuanaCelik requested a review from ZanSara August 10, 2022 07:47
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jamescalam, I agree this seems like over-testing some assumptions on our end. We don't guarantee any specific ordering in get_labels, so this is perfectly fine. Thank you for the PR!

@jamescalam jamescalam mentioned this pull request Aug 10, 2022
6 tasks
@ZanSara ZanSara merged commit 524c9b9 into deepset-ai:master Aug 10, 2022
@jamescalam jamescalam deleted the doc-store-test-labels branch August 10, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document store tests raise error if order of returned labels not as expected
3 participants