Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "text" to "content" as dict key #2800

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

julian-risch
Copy link
Member

Documentation of write_documents mentioned the old dict key (and Document attribute) text. This PR replaces the two occurrences of text in the docstring with content.

@julian-risch julian-risch requested a review from brandenchan July 13, 2022 11:16
@julian-risch julian-risch added ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs topic:document_store labels Jul 13, 2022
@julian-risch julian-risch changed the title change "text" to "content" as dict key Change "text" to "content" as dict key Jul 13, 2022
@julian-risch julian-risch marked this pull request as draft July 13, 2022 13:00
@julian-risch julian-risch marked this pull request as ready for review July 13, 2022 13:00
@julian-risch julian-risch merged commit f599ce9 into master Jul 13, 2022
@julian-risch julian-risch deleted the fix-write-documents-documentation branch July 13, 2022 14:36
Krak91 pushed a commit to Krak91/haystack that referenced this pull request Jul 26, 2022
* change "text" to "content" as dict key

* Update Documentation & Code Style

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:document_store type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants