Mocking Pinecone tests

[ZanSara]

Related Issue(s): #2644

Proposed changes:

• Replace the live calls to Pinecone in tests with the mock client provided by @jamescalam in added mock pinecone client #2770

Pre-flight checklist

• I have read the contributors guidelines
• I have enabled actions on my fork
• If this is a code change, I added tests or updated existing ones
• [ ] If this is a code change, I updated the docstrings

[ZanSara]

@jamescalam: the mock did not accept this parameter. As I imagine the mock represents the actual contract with Pinecone, I assumed this might be a leftover from older versions and removed it.

Is that true? If not, I will revert this change and add delete_all to the mock.

[jamescalam]

delete_all should be included in the mock

[ZanSara]

@jamescalam: Your mock works really nicely! Thank you so much for it 😊

I have only one test failing that I can't understand well:

haystack/test/document_stores/test_document_store.py

Line 1165 in ea40387

def test_update_meta(document_store: BaseDocumentStore):

test/document_stores/test_document_store.py::test_update_meta[pinecone] - ValueError: Namespace not found

I think you should be able to clone this branch and run the test locally to see the issue, otherwise you can see the logs here: https://github.com/deepset-ai/haystack/actions/runs/2634797675 How can I fix the mock to make this test pass?

[jamescalam]

Replace this line with pass to fix:

haystack/test/mocks/pinecone.py

Line 90 in f1b3e40

raise ValueError("Namespace not found")

This aligns with Pinecone where if we query an empty/non-existent namespace in Pinecone it will just return an empty response (not raise a ValueError)

[jamescalam]

Replace this line with pass to fix:

haystack/test/mocks/pinecone.py

Line 90 in f1b3e40

raise ValueError("Namespace not found")

This aligns with Pinecone where if we query an empty/non-existent namespace in Pinecone it will just return an empty response (not raise a ValueError)

Sorry, it should be return response as it needs to return the empty response format we define at the start of the method (this is what Pinecone would return)

[jamescalam]

@ZanSara the Tests / pinecone-tests-linux error seems valid, I will look at the document store code to fix

[jamescalam]

@ZanSara this should work with the newer document_store #2749 - it will not work with the old one because the format of fetch requests have changed

[jamescalam]

Looks good for Pinecone doc store + mock 😁

[ZanSara]

Great, thanks! I will merge this as soon as that strange failure with the rest api tests is sorted (we just enabled a new branch protection rule for master and is not going as smoothly as we hoped 😅 )

[masci]

Bingo! :)