fix: serialization of pipeline_outputs in pipeline snapshot
#10096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Amnah199
added
the
ignore-for-release-notes
Amnah199
removed
the
ignore-for-release-notes
Contributor
|
@Amnah199 this is technically a breaking change b/c existing pipeline snapshots would no longer be loadable right? |
…rialize-pipleine-outputs
Contributor
Author
|
@sjrl you are right! Its a breaking change. Do you think I should try to make it backward compatible and log a warning before we decide to remove that support in next releases? |
Member
|
Not an expert on this topic, but I'll try to review... @Amnah199 let's make it backward compatible (if possible) and add tests to show existing pipeline snapshots are still loadable. |
Collaborator
Pull Request Test Coverage Report for Build 19826642961Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
9 tasks
anakin87
reviewed
Dec 1, 2025
GunaPalanivel
added a commit
to GunaPalanivel/haystack
that referenced
this pull request
Dec 15, 2025
Remove temporary deserialization logic for old pipeline_outputs format in pipeline snapshots. This backward-compatibility layer was introduced in PR deepset-ai#10096 and marked for removal in Haystack 2.23.0. BREAKING CHANGE: Pipeline snapshots created before Haystack 2.17.0 will no longer deserialize correctly. Users must recreate snapshots with the current Haystack version or manually migrate to the new serialization schema. Changes: - Remove conditional deserialization check in Pipeline.run() - Remove test_load_pipeline_snapshot_with_old_pipeline_outputs_format test - Add breaking change documentation with migration instructions The new format uses 'serialization_schema' and 'serialized_data' fields, consistent with other pipeline state serialization. Closes deepset-ai#10168 Ref deepset-ai#10096
12 tasks
GunaPalanivel
added a commit
to GunaPalanivel/haystack
that referenced
this pull request
Jan 13, 2026
Remove temporary deserialization logic for old pipeline_outputs format in pipeline snapshots. This backward-compatibility layer was introduced in PR deepset-ai#10096 and marked for removal in Haystack 2.23.0. BREAKING CHANGE: Pipeline snapshots created before Haystack 2.17.0 will no longer deserialize correctly. Users must recreate snapshots with the current Haystack version or manually migrate to the new serialization schema. Changes: - Remove conditional deserialization check in Pipeline.run() - Remove test_load_pipeline_snapshot_with_old_pipeline_outputs_format test - Add breaking change documentation with migration instructions The new format uses 'serialization_schema' and 'serialized_data' fields, consistent with other pipeline state serialization. Closes deepset-ai#10168 Ref deepset-ai#10096
anakin87
added a commit
that referenced
this pull request
Jan 14, 2026
…at (#10249) Remove temporary deserialization logic for old pipeline_outputs format in pipeline snapshots. This backward-compatibility layer was introduced in PR #10096 and marked for removal in Haystack 2.23.0. BREAKING CHANGE: Pipeline snapshots created before Haystack 2.17.0 will no longer deserialize correctly. Users must recreate snapshots with the current Haystack version or manually migrate to the new serialization schema. Changes: - Remove conditional deserialization check in Pipeline.run() - Remove test_load_pipeline_snapshot_with_old_pipeline_outputs_format test - Add breaking change documentation with migration instructions The new format uses 'serialization_schema' and 'serialized_data' fields, consistent with other pipeline state serialization. Closes #10168 Ref #10096 Co-authored-by: Stefano Fiorucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
pipeline_outputswhen creating aPipelineSnapshot#9872Proposed Changes:
pipeline_outputsin pipeline snapshot.pipeline_outputsfrom pipeline snapshot #10168How did you test it?
Updated tests
Locally tested with the example in the issue
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.