added Browserbase fetcher #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @TuanaCelik, sorry for bothering. Could I ask to for a review and get this merged? Can't wait to announce our Haystack integration 😄 |
TuanaCelik
reviewed
May 2, 2024
integrations/browserbase.md
Outdated
| llm = OpenAIGenerator() | ||
|
|
||
| pipe = Pipeline() | ||
| pipe.add_component("fetcher", self.browserbase_fetcher) |
There was a problem hiding this comment.
Let's initialize this in this code block rather than referring to self.browserbase_fetcher
|
hi @mishushakov thanks for the contribution. Could you add some more information on browserbase at the top. When would people use it? Does the platform provide any way to observe searches? |
|
Thanks for your quick reply! Does this look finished enough? 😅 |
|
Just letting you know: we're ready for another review |
|
Can we get a green light on this one, @TuanaCelik? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds Browserbase fetcher to Haystack