Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change ollama output name to 'meta' #670

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

Rusteam
Copy link
Contributor

@Rusteam Rusteam commented Apr 18, 2024

Currently it fails with hayhooks with:

llm-rest-api   | pydantic_core._pydantic_core.ValidationError: 1 validation error for Pipe_ragRunResponse
llm-rest-api   | llm.metadata
llm-rest-api   |   Field required [type=missing, input_value={'replies': ['\nTo answer..._duration': 844273000}]}, input_type=dict]
llm-rest-api   |     For further information visit https://errors.pydantic.dev/2.6/v/missing

because in output types it mentions metadata not meta. This fixed it

@Rusteam Rusteam requested a review from a team as a code owner April 18, 2024 10:24
@Rusteam Rusteam requested review from davidsbatista and removed request for a team April 18, 2024 10:24
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@anakin87
Copy link
Member

@Rusteam thanks for this fix!

I'll merge this PR as soon as the CLA is signed.

@Rusteam
Copy link
Contributor Author

Rusteam commented Apr 18, 2024

singed the CLA, although I felt it requires too many permissions

@anakin87 anakin87 merged commit 61bdcd6 into deepset-ai:main Apr 18, 2024
7 checks passed
@anakin87
Copy link
Member

Thanks. Released a new version: https://pypi.org/project/ollama-haystack/0.0.6/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants