Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated convert_13_to_21 #1986

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 12, 2022

Strange, I added duplicated convert_13_to_21 in #1597.

Strange, I added duplicated `convert_13_to_21` in deepmodeling#1597.

Signed-off-by: Jinzhe Zeng <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 73.56% // Head: 28.97% // Decreases project coverage by -44.58% ⚠️

Coverage data is based on head (7784c2e) compared to base (77c7ad4).
Patch has no changes to coverable lines.

❗ Current head 7784c2e differs from pull request most recent head 8bfd008. Consider uploading reports for the commit 8bfd008 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #1986       +/-   ##
===========================================
- Coverage   73.56%   28.97%   -44.59%     
===========================================
  Files         198      196        -2     
  Lines       19916    18306     -1610     
  Branches      854        0      -854     
===========================================
- Hits        14651     5305     -9346     
- Misses       4877    13001     +8124     
+ Partials      388        0      -388     
Impacted Files Coverage Δ
deepmd/utils/convert.py 19.44% <ø> (+0.47%) ⬆️
source/op/soft_min_virial_grad.cc 3.63% <0.00%> (-90.96%) ⬇️
source/op/soft_min_virial.cc 3.84% <0.00%> (-90.60%) ⬇️
source/op/prod_virial_grad_multi_device.cc 1.55% <0.00%> (-89.96%) ⬇️
source/op/soft_min_force_grad.cc 4.08% <0.00%> (-89.86%) ⬇️
source/op/prod_force_grad_multi_device.cc 1.73% <0.00%> (-88.78%) ⬇️
deepmd/nvnmd/entrypoints/wrap.py 7.51% <0.00%> (-88.73%) ⬇️
deepmd/nvnmd/entrypoints/mapt.py 11.37% <0.00%> (-88.16%) ⬇️
source/op/soft_min_force.cc 5.00% <0.00%> (-87.86%) ⬇️
source/op/soft_min.cc 3.07% <0.00%> (-87.84%) ⬇️
... and 129 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit 2486918 into deepmodeling:devel Oct 13, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
Strange, I added duplicated `convert_13_to_21` in deepmodeling#1597.

Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants