Skip to content

add unittests for LAMMPS pair deepmd #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 11, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 8, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Base: 75.71% // Head: 73.56% // Decreases project coverage by -2.14% ⚠️

Coverage data is based on head (3dbe7e3) compared to base (6733a06).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1977      +/-   ##
==========================================
- Coverage   75.71%   73.56%   -2.15%     
==========================================
  Files         191      198       +7     
  Lines       18695    19915    +1220     
  Branches      854      854              
==========================================
+ Hits        14154    14651     +497     
- Misses       4153     4876     +723     
  Partials      388      388              
Impacted Files Coverage Δ
deepmd/entrypoints/main.py 90.83% <ø> (+3.33%) ⬆️
deepmd/entrypoints/convert.py 60.00% <100.00%> (+44.61%) ⬆️
source/op/prod_force_grad_multi_device.cc 90.51% <0.00%> (-6.37%) ⬇️
source/op/prod_virial_grad_multi_device.cc 91.50% <0.00%> (-5.72%) ⬇️
source/op/soft_min_force_grad.cc 93.93% <0.00%> (-4.48%) ⬇️
source/op/soft_min_virial_grad.cc 94.59% <0.00%> (-4.00%) ⬇️
source/op/prod_force_grad.cc 77.47% <0.00%> (-2.90%) ⬇️
source/op/prod_virial_grad.cc 79.33% <0.00%> (-2.72%) ⬇️
source/lib/include/SimulationRegion.h 25.00% <0.00%> (-2.28%) ⬇️
source/api_cc/src/common.cc 85.46% <0.00%> (-0.99%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz njzjz marked this pull request as ready for review October 8, 2022 05:35
@njzjz njzjz requested a review from wanghan-iapcm October 8, 2022 05:35
@njzjz
Copy link
Member Author

njzjz commented Oct 8, 2022

This PR is ok. More tests can be added in the coming PRs.

image

@njzjz njzjz changed the title add LAMMPS unittest add LAMMPS unittests Oct 8, 2022
@njzjz njzjz requested a review from wanghan-iapcm October 8, 2022 07:59
@njzjz njzjz requested a review from wanghan-iapcm October 10, 2022 01:00
@njzjz njzjz changed the title add LAMMPS unittests add LAMMPS pair deepmd unittests Oct 10, 2022
@njzjz njzjz changed the title add LAMMPS pair deepmd unittests add unittests for LAMMPS pair deepmd Oct 10, 2022
@wanghan-iapcm wanghan-iapcm merged commit 0f4dc3c into deepmodeling:devel Oct 11, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants