Skip to content

LAMMPS: Use of “override” instead of “virtual” #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 14, 2022

fix #1855.

@njzjz
Copy link
Member Author

njzjz commented Sep 14, 2022

Looks good.

@njzjz njzjz marked this pull request as ready for review September 14, 2022 07:29
@njzjz njzjz linked an issue Sep 14, 2022 that may be closed by this pull request
@njzjz njzjz requested a review from wanghan-iapcm September 14, 2022 07:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1915 (bf68f3a) into devel (716cb5d) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #1915      +/-   ##
==========================================
+ Coverage   78.00%   78.02%   +0.02%     
==========================================
  Files         118      114       -4     
  Lines        9853     9840      -13     
==========================================
- Hits         7686     7678       -8     
+ Misses       2167     2162       -5     
Impacted Files Coverage Δ
source/api_cc/include/DeepPot.h
source/lib/include/neighbor_list.h
source/lib/include/SimulationRegion.h
source/api_cc/include/DeepTensor.h

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 58bed2b into deepmodeling:devel Sep 14, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
@ZhengdQin
Copy link
Contributor

Hi jinzhe,

I want commit based on your commit, could you please tell me how to pass this checks. I got the same problems. You can find my code at https://github.com/ZhengdQin/deepmd-kit/tree/ascend . Thanks.
image

@njzjz njzjz deleted the lmp-override branch March 8, 2023 19:06
@njzjz
Copy link
Member Author

njzjz commented Mar 8, 2023

The old checks might be out-of-date. @wanghan-iapcm Is there any reason not to merge with the latest commit?

@njzjz
Copy link
Member Author

njzjz commented Mar 8, 2023

By the way, @ZhengdQin could you send me your email address?

@ZhengdQin
Copy link
Contributor

By the way, @ZhengdQin could you send me your email address?

[email protected] is my email. I tred to merge to the latest commit but it leads to some new problems, and my colleagues want to use it as soon as possible, so I decided to merge to ascend branch first and try to merge to the latest commit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LAMMPS: Use of “override” instead of “virtual”
4 participants