Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type-compiler): include enum annotations in .d.ts transformation #607

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

kuesutodev
Copy link
Contributor

@kuesutodev kuesutodev commented Aug 15, 2024

Summary of changes

Exported enums seem to not generate __Ω annotations in their respective .d.ts files. This leads to Symbol ___Ω not found in... type errors when other packages want to use those definitions.

Adding this check seems to have the desired effect and looks like one of the other checks above: https://github.com/deepkit/deepkit-framework/blob/master/packages/type-compiler/src/compiler.ts#L910

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@marcj marcj merged commit 08854f3 into deepkit:master Sep 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants