Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): strings should be nullable without casting as JSON #552

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

fergusean
Copy link
Contributor

Summary of changes

The other typeResolvesToX functions filter out undefined/null before determining if the type correctly resolves, but string does not. As a result, string | null types on database entities are being coerced to JSON.

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e09ddf) 78.06% compared to head (287c853) 78.06%.

❗ Current head 287c853 differs from pull request most recent head 284bef3. Consider uploading reports for the commit 284bef3 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   78.06%   78.06%           
=======================================
  Files         191      191           
  Lines       20296    20296           
  Branches     5255     5255           
=======================================
  Hits        15844    15844           
  Misses       4452     4452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcj marcj merged commit fe55b7f into deepkit:master Feb 10, 2024
6 checks passed
@marcj
Copy link
Member

marcj commented Feb 10, 2024

thanks @fergusean !

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants