Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): intersection of two different primitives #549

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

M-jerez
Copy link
Contributor

@M-jerez M-jerez commented Feb 7, 2024

Summary of changes

  • The intersection of two different primitive types always return never
  • Add an extra test case for properties overriding on object intersection

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (732feec) 78.15% compared to head (dd393f4) 78.18%.

❗ Current head dd393f4 differs from pull request most recent head 645c625. Consider uploading reports for the commit 645c625 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
+ Coverage   78.15%   78.18%   +0.03%     
==========================================
  Files         191      191              
  Lines       20298    20300       +2     
  Branches     5258     5259       +1     
==========================================
+ Hits        15864    15872       +8     
+ Misses       4434     4428       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcj marcj merged commit 20d3dc8 into deepkit:master Feb 10, 2024
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants