Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mongo,sql): skip database field for inserts #527

Merged

Conversation

marcus-sa
Copy link
Contributor

Summary of changes

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29a1a17) 77.77% compared to head (2bbdde2) 77.77%.

❗ Current head 2bbdde2 differs from pull request most recent head 5e651c5. Consider uploading reports for the commit 5e651c5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files         188      188           
  Lines       20091    20095    +4     
  Branches     5202     5203    +1     
=======================================
+ Hits        15625    15629    +4     
  Misses       4466     4466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcus-sa marcus-sa force-pushed the fix/sql-insert-skip-database-field-2 branch from 6b2177a to 8091dda Compare December 27, 2023 22:44
@marcus-sa marcus-sa changed the title fix(sql): skip database field for inserts feat(sql): skip database field for inserts Dec 27, 2023
@marcus-sa marcus-sa force-pushed the fix/sql-insert-skip-database-field-2 branch 2 times, most recently from c42492e to 8feee44 Compare December 27, 2023 23:01
@marcus-sa marcus-sa force-pushed the fix/sql-insert-skip-database-field-2 branch from 8feee44 to 5be6966 Compare December 27, 2023 23:12
@marcus-sa marcus-sa changed the title feat(sql): skip database field for inserts feat(orm): skip database field for inserts Dec 28, 2023
@marcus-sa marcus-sa changed the title feat(orm): skip database field for inserts feat(mongo,sql): skip database field for inserts Dec 28, 2023
@marcus-sa marcus-sa force-pushed the fix/sql-insert-skip-database-field-2 branch from 137b963 to 5e651c5 Compare December 28, 2023 11:07
@marcj marcj merged commit 9fca388 into deepkit:master Jan 8, 2024
5 checks passed
@marcj
Copy link
Member

marcj commented Jan 8, 2024

nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants