Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): use NoopStopwatchStore when debugger is disabled #502

Closed

Conversation

marcus-sa
Copy link
Contributor

@marcus-sa marcus-sa commented Oct 31, 2023

Summary of changes

Use NoopStopwatchStore instead of FileStopwatchStore when debugging is disabled.

Fixes the following error

unhandledRejection [Error: ENOENT: no such file or directory, open 'var/debug/frames.bin'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'var/debug/frames.bin'
}

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@marcus-sa marcus-sa force-pushed the test/disable-debug-profiler branch 3 times, most recently from 18bbf0e to 7b2ddd3 Compare October 31, 2023 09:04
@marcus-sa marcus-sa changed the title test(framework): disable debug profiler in application server tests test(framework): disable debugging for http worker application server tests Oct 31, 2023
@marcus-sa marcus-sa changed the title test(framework): disable debugging for http worker application server tests feat(framework,stopwatch): add NoopStopwatchStore Oct 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #502 (6da4e22) into master (aadc4b9) will decrease coverage by 0.23%.
Report is 7 commits behind head on master.
The diff coverage is 40.95%.

❗ Current head 6da4e22 differs from pull request most recent head 4d5eec2. Consider uploading reports for the commit 4d5eec2 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   77.83%   77.60%   -0.23%     
==========================================
  Files         184      184              
  Lines       19604    19770     +166     
  Branches     5057     5101      +44     
==========================================
+ Hits        15259    15343      +84     
- Misses       4345     4427      +82     
Files Coverage Δ
packages/framework/src/application-server.ts 59.18% <100.00%> (+0.20%) ⬆️
packages/framework/src/module.config.ts 100.00% <ø> (ø)
packages/framework/src/rpc.ts 97.72% <100.00%> (+69.82%) ⬆️
packages/rpc/src/server/kernel.ts 82.06% <ø> (ø)
packages/type/src/reflection/processor.ts 96.09% <100.00%> (+<0.01%) ⬆️
packages/type/src/reflection/reflection.ts 68.71% <100.00%> (-0.30%) ⬇️
packages/type/src/reflection/type.ts 82.82% <ø> (-0.02%) ⬇️
packages/broker/src/adapters/deepkit-adapter.ts 86.57% <0.00%> (ø)
packages/framework/src/debug/broker.ts 70.58% <66.66%> (ø)
packages/http/src/kernel.ts 87.75% <0.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marcus-sa marcus-sa changed the title feat(framework,stopwatch): add NoopStopwatchStore fix(framework): use NoopStopwatchStore when debugger is disabled Oct 31, 2023
@marcj
Copy link
Member

marcj commented Nov 9, 2023

Fixed in 52a7e52

@marcj marcj closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants