Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): ensure both types have names before comparing in isSameType function #474

Merged

Conversation

marcus-sa
Copy link
Contributor

@marcus-sa marcus-sa commented Sep 10, 2023

Summary of changes

Fixes the failing basic union with number | uuid test in bson package

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

…ction

Fixes failing `basic union with number | uuid` test in bson package
@marcus-sa marcus-sa changed the title fix(type): ensure types have names before comparing in isSameType function fix(type): ensure both types have names before comparing in isSameType function Sep 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Merging #474 (bc77ca8) into master (3fd48ea) will decrease coverage by 0.04%.
Report is 6 commits behind head on master.
The diff coverage is 62.06%.

❗ Current head bc77ca8 differs from pull request most recent head 177fa1b. Consider uploading reports for the commit 177fa1b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   78.37%   78.33%   -0.04%     
==========================================
  Files         173      173              
  Lines       18538    18548      +10     
  Branches     4843     4845       +2     
==========================================
+ Hits        14529    14530       +1     
- Misses       4009     4018       +9     
Files Changed Coverage Δ
packages/core/src/compiler.ts 58.92% <16.66%> (-5.08%) ⬇️
packages/type/src/path.ts 80.48% <37.50%> (-8.09%) ⬇️
packages/type/src/serializer.ts 92.53% <87.50%> (+0.15%) ⬆️
packages/bson/src/bson-deserializer-templates.ts 95.65% <100.00%> (ø)
packages/bson/src/bson-serializer.ts 86.67% <100.00%> (ø)
packages/type/src/change-detector.ts 85.43% <100.00%> (ø)
packages/type/src/reflection/processor.ts 95.59% <100.00%> (+<0.01%) ⬆️
packages/type/src/reflection/type.ts 82.84% <100.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marcj marcj merged commit 0ed13d0 into deepkit:master Oct 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants