feat(app): allow normalized providers to be exported in modules #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it's only possible to export interface providers using `this.addExport(provider)` in modules, where `provider` refers to an interface provider. This aims to try to solve that by allowing `NormalizedProvider`s to be exported.
|
Nice, thanks! |
marcj
added a commit
that referenced
this pull request
Oct 3, 2023
|
This wasn't working in master (test was not green and necessary adjustments were not made), so I fixed it in 76ec217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Currently, it's only possible to export interface providers using
this.addExport(provider)in modules. This aims to try to solve that by allowingNormalizedProviders to be exported directly increateModule.https://discord.com/channels/759513055117180999/956486106709364776/1089925501113614527
Relinquishment of Rights
Please mark following checkbox to confirm that you relinquish all rights of your changes: