Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Fixes memory leak #3433

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[rust] Fixes memory leak #3433

merged 1 commit into from
Aug 20, 2024

Conversation

frankfliu
Copy link
Contributor

Fixes: #3413

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners August 20, 2024 17:49
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.38%. Comparing base (cb898a6) to head (ffbbc4e).
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3433       +/-   ##
=============================================
- Coverage     72.53%   58.38%   -14.15%     
+ Complexity     7372     5786     -1586     
=============================================
  Files           668      669        +1     
  Lines         32629    32658       +29     
  Branches       3468     3474        +6     
=============================================
- Hits          23667    19068     -4599     
- Misses         7347    12116     +4769     
+ Partials       1615     1474      -141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit 5042fc4 into deepjavalibrary:master Aug 20, 2024
5 checks passed
@frankfliu frankfliu deleted the rs branch August 20, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory Leak when calling RsNDArray.toByteBuffer()
3 participants