Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tokenizers] Download jni lib files for cuda #3326

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Jul 11, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk, frankfliu and a team as code owners July 11, 2024 16:02
+ flavor
+ '/'
+ LIB_NAME;
logger.info("Downloading jni {} to cache ...", url);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We don't have cuda for windows
  2. We may only want to support cuda12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 72.92%. Comparing base (36bf6d6) to head (4893401).
Report is 1 commits behind head on master.

Files Patch % Lines
...va/ai/djl/huggingface/tokenizers/jni/LibUtils.java 16.00% 20 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3326      +/-   ##
============================================
- Coverage     72.99%   72.92%   -0.07%     
+ Complexity     7329     7327       -2     
============================================
  Files           668      668              
  Lines         32390    32414      +24     
  Branches       3415     3418       +3     
============================================
- Hits          23643    23639       -4     
- Misses         7139     7168      +29     
+ Partials       1608     1607       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xyang16 xyang16 merged commit dfdf93b into deepjavalibrary:master Jul 11, 2024
12 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants