Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Adds utility method to Model for accessing properties #3007

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners February 27, 2024 21:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (19e4302) to head (5226348).
Report is 449 commits behind head on master.

Files with missing lines Patch % Lines
api/src/main/java/ai/djl/Model.java 50.00% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3007   +/-   ##
=========================================
  Coverage     72.29%   72.29%           
- Complexity     7284     7287    +3     
=========================================
  Files           722      722           
  Lines         32483    32491    +8     
  Branches       3388     3390    +2     
=========================================
+ Hits          23484    23490    +6     
- Misses         7384     7385    +1     
- Partials       1615     1616    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit 8a88c35 into deepjavalibrary:master Feb 28, 2024
5 checks passed
@frankfliu frankfliu deleted the api branch February 28, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants