Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ci] avoid early exit of script for failure case #2979

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Feb 5, 2024

Description

publish-job-success workflow exits with failure because one of the script steps returns exit code 1 when the triggering workflow fails.

@siddvenk siddvenk requested review from zachgk, frankfliu and a team as code owners February 5, 2024 18:18
@codecov-commenter
Copy link

Codecov Report

Attention: 1339 lines in your changes are missing coverage. Please review.

Comparison is base (bb5073f) 72.08% compared to head (4b4a349) 72.23%.
Report is 985 commits behind head on master.

Files Patch % Lines
...va/ai/djl/modality/nlp/generate/TextGenerator.java 2.81% 276 Missing ⚠️
.../java/ai/djl/modality/nlp/generate/SeqBatcher.java 0.75% 132 Missing ⚠️
...ity/nlp/generate/ContrastiveSeqBatchScheduler.java 2.97% 98 Missing ⚠️
...i/djl/modality/nlp/generate/SeqBatchScheduler.java 9.83% 55 Missing ⚠️
.../java/ai/djl/modality/cv/BufferedImageFactory.java 40.96% 47 Missing and 2 partials ⚠️
...a/ai/djl/modality/nlp/generate/StepGeneration.java 2.04% 48 Missing ⚠️
api/src/main/java/ai/djl/ndarray/NDArray.java 43.42% 39 Missing and 4 partials ⚠️
...n/java/ai/djl/modality/cv/output/CategoryMask.java 22.00% 39 Missing ⚠️
...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java 71.21% 31 Missing and 7 partials ⚠️
.../cv/translator/SemanticSegmentationTranslator.java 37.50% 35 Missing ⚠️
... and 74 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2979      +/-   ##
============================================
+ Coverage     72.08%   72.23%   +0.14%     
- Complexity     5126     7287    +2161     
============================================
  Files           473      722     +249     
  Lines         21970    32513   +10543     
  Branches       2351     3392    +1041     
============================================
+ Hits          15838    23487    +7649     
- Misses         4925     7409    +2484     
- Partials       1207     1617     +410     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siddvenk siddvenk merged commit e3089d6 into deepjavalibrary:master Feb 5, 2024
5 checks passed
@siddvenk siddvenk deleted the fix-cw-actions branch February 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants