Yelov8 Translator optimization #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved post-processing performance up to 40x by reducing expensive native calls - Additional argument 'maxBox' added to improve post-processing performance by reducing number of considered bounding boxes - Sunset file fixed,, previous version ignored first 4 rows, so recognized classes were 4 off. Adding 4 rows header fixes the problem. New headers pointing to ultralytics doc pages and original coco dataset page.
frankfliu
reviewed
Dec 31, 2023
| @@ -27,13 +29,17 @@ | |||
| */ | |||
| public class YoloV8Translator extends YoloV5Translator { | |||
|
|
|||
|
|
|||
| final int maxBoxes; | |||
There was a problem hiding this comment.
The usage of final for members and parameters is generally discouraged in favor of readability.
See: https://docs.djl.ai/docs/development/development_guideline.html#coding-conventions
| int sizeClasses = classes.size(); | ||
| long sizeBoxes = features4OneImg.size(1); | ||
| ArrayList<IntermediateResult> intermediateResults = new ArrayList<>(); | ||
| final NDArray rawResult = list.get(0); |
| @@ -65,6 +65,8 @@ public static DetectedObjects predict() throws IOException, ModelException, Tran | |||
| arguments.put("toTensor", true); | |||
| arguments.put("applyRatio", true); | |||
| arguments.put("threshold", 0.6f); | |||
| // for performance optimization maxBox parameter can reduce number of considered boxes from 8400 | |||
There was a problem hiding this comment.
We follow AOPS coding convention. Please reformat your code with the following command:
./gradlew fJ
- reformatted code - removed final
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2908 +/- ##
============================================
+ Coverage 72.08% 72.56% +0.47%
- Complexity 5126 7203 +2077
============================================
Files 473 708 +235
Lines 21970 32022 +10052
Branches 2351 3337 +986
============================================
+ Hits 15838 23238 +7400
- Misses 4925 7189 +2264
- Partials 1207 1595 +388 ☔ View full report in Codecov by Sentry. |
1. Fixes windows line return 2. Furthe reduce NDArray operations 3. Refactor example code 4. Add unittest for Yolov8Detection
frankfliu
approved these changes
Dec 31, 2023
frankfliu
added a commit
that referenced
this pull request
Apr 26, 2024
* Yelov8 Translator optimization - Improved post-processing performance up to 40x by reducing expensive native calls - Additional argument 'maxBox' added to improve post-processing performance by reducing number of considered bounding boxes - Sunset file fixed,, previous version ignored first 4 rows, so recognized classes were 4 off. Adding 4 rows header fixes the problem. New headers pointing to ultralytics doc pages and original coco dataset page. * addressed PR comments - reformatted code - removed final * Refactor Yolov8 example 1. Fixes windows line return 2. Furthe reduce NDArray operations 3. Refactor example code 4. Add unittest for Yolov8Detection --------- Co-authored-by: Frank Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Improved post-processing performance up to 40x by reducing expensive native calls
Additional argument 'maxBox' added to improve post-processing performance by reducing number of considered bounding boxes
Sunset file fixed,, previous version ignored first 4 rows, so recognized classes were 4 off. Adding 4 rows header fixes the problem. New headers pointing to ultralytics doc pages and original coco dataset page.
Change on yolov8_synset.txt is a backward incompatible, example sunset file was incorrectly formatted and predicted class categories were off by 4.