Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes archiveBaseName in native builds #2859

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Nov 18, 2023

This property is necessary to avoid conflicts in building multiple flavors which can be observed in the native properties file not matching the jar for some engine builds.

This property is necessary to avoid conflicts in building multiple flavors which
can be observed in the native properties file not matching the jar for some
engine builds.
@zachgk zachgk requested review from frankfliu and a team as code owners November 18, 2023 00:40
@codecov-commenter
Copy link

Codecov Report

Attention: 1365 lines in your changes are missing coverage. Please review.

Comparison is base (bb5073f) 72.08% compared to head (0cc3c0f) 72.11%.
Report is 913 commits behind head on master.

Files Patch % Lines
...va/ai/djl/modality/nlp/generate/TextGenerator.java 2.81% 276 Missing ⚠️
.../java/ai/djl/modality/nlp/generate/SeqBatcher.java 0.75% 132 Missing ⚠️
...ity/nlp/generate/ContrastiveSeqBatchScheduler.java 2.97% 98 Missing ⚠️
...i/djl/modality/nlp/generate/SeqBatchScheduler.java 9.83% 55 Missing ⚠️
.../java/ai/djl/modality/cv/BufferedImageFactory.java 40.96% 47 Missing and 2 partials ⚠️
...a/ai/djl/modality/nlp/generate/StepGeneration.java 2.04% 48 Missing ⚠️
api/src/main/java/ai/djl/ndarray/NDArray.java 43.42% 39 Missing and 4 partials ⚠️
...n/java/ai/djl/modality/cv/output/CategoryMask.java 22.00% 39 Missing ⚠️
...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java 71.21% 31 Missing and 7 partials ⚠️
.../cv/translator/SemanticSegmentationTranslator.java 37.50% 35 Missing ⚠️
... and 76 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2859      +/-   ##
============================================
+ Coverage     72.08%   72.11%   +0.02%     
- Complexity     5126     7145    +2019     
============================================
  Files           473      708     +235     
  Lines         21970    31915    +9945     
  Branches       2351     3314     +963     
============================================
+ Hits          15838    23016    +7178     
- Misses         4925     7318    +2393     
- Partials       1207     1581     +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachgk zachgk merged commit a30f133 into deepjavalibrary:master Nov 20, 2023
5 checks passed
@zachgk zachgk deleted the archiveBaseName branch November 20, 2023 18:16
frankfliu pushed a commit that referenced this pull request Apr 26, 2024
This property is necessary to avoid conflicts in building multiple flavors which
can be observed in the native properties file not matching the jar for some
engine builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants