Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erf and atan2 #2842

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Add erf and atan2 #2842

merged 5 commits into from
Nov 9, 2023

Conversation

TalGrbr
Copy link
Contributor

@TalGrbr TalGrbr commented Nov 8, 2023

Description

Added erf and atan2 operators for arrays

@TalGrbr TalGrbr requested review from zachgk, frankfliu and a team as code owners November 8, 2023 15:25
@lanking520
Copy link
Contributor

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 1360 lines in your changes are missing coverage. Please review.

Comparison is base (bb5073f) 72.08% compared to head (7bf4063) 72.32%.
Report is 907 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2842      +/-   ##
============================================
+ Coverage     72.08%   72.32%   +0.23%     
- Complexity     5126     7158    +2032     
============================================
  Files           473      708     +235     
  Lines         21970    31892    +9922     
  Branches       2351     3313     +962     
============================================
+ Hits          15838    23066    +7228     
- Misses         4925     7248    +2323     
- Partials       1207     1578     +371     
Files Coverage Δ
...ava/ai/djl/inference/streaming/StreamingBlock.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/metric/Dimension.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/metric/Unit.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/modality/audio/Audio.java 100.00% <100.00%> (ø)
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...ava/ai/djl/modality/cv/output/DetectedObjects.java 96.29% <100.00%> (+1.29%) ⬆️
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <100.00%> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...i/djl/modality/cv/transform/RandomResizedCrop.java 94.11% <100.00%> (+5.22%) ⬆️
... and 225 more

... and 385 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @TalGrbr!

@zachgk zachgk merged commit f84d3bb into deepjavalibrary:master Nov 9, 2023
5 checks passed
@TalGrbr TalGrbr mentioned this pull request Nov 9, 2023
frankfliu pushed a commit that referenced this pull request Apr 26, 2024
* Added element-wise gauss error function (ERF)

* Added element-wise arctan2

* Format java

* Fixed docs

* added * to other_ptr in Atan2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants