Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Masks sensitive env vars in debug print out #2657

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners June 15, 2023 15:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (bb5073f) to head (3f9380e).
Report is 1331 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2657      +/-   ##
============================================
+ Coverage     72.08%   73.46%   +1.37%     
- Complexity     5126     6962    +1836     
============================================
  Files           473      685     +212     
  Lines         21970    30457    +8487     
  Branches       2351     3157     +806     
============================================
+ Hits          15838    22374    +6536     
- Misses         4925     6549    +1624     
- Partials       1207     1534     +327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit 8596e2e into deepjavalibrary:master Jun 15, 2023
@frankfliu frankfliu deleted the env branch June 15, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants