Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spi: Introduce dependencise for Phytium to avoid warnings #376

Merged

Conversation

Avenger-285714
Copy link
Collaborator

Fix follow warnings in Kconfig:

WARNING: unmet direct dependencies detected for SPI_PHYTIUM
Depends on [n]: SPI [=y] && SPI_MASTER [=y] && (ARCH_PHYTIUM || COMPILE_TEST [=n])
Selected by [m]:

  • SPI_PHYTIUM_PLAT [=m] && SPI [=y] && SPI_MASTER [=y]
  • SPI_PHYTIUM_PCI [=m] && SPI [=y] && SPI_MASTER [=y] && PCI [=y]

WARNING: unmet direct dependencies detected for SPI_PHYTIUM
Depends on [n]: SPI [=y] && SPI_MASTER [=y] && (ARCH_PHYTIUM || COMPILE_TEST [=n])
Selected by [m]:

  • SPI_PHYTIUM_PLAT [=m] && SPI [=y] && SPI_MASTER [=y]
  • SPI_PHYTIUM_PCI [=m] && SPI [=y] && SPI_MASTER [=y] && PCI [=y]

Fix follow warnings in Kconfig:

WARNING: unmet direct dependencies detected for SPI_PHYTIUM
  Depends on [n]: SPI [=y] && SPI_MASTER [=y] && (ARCH_PHYTIUM || COMPILE_TEST [=n])
  Selected by [m]:
  - SPI_PHYTIUM_PLAT [=m] && SPI [=y] && SPI_MASTER [=y]
  - SPI_PHYTIUM_PCI [=m] && SPI [=y] && SPI_MASTER [=y] && PCI [=y]

WARNING: unmet direct dependencies detected for SPI_PHYTIUM
  Depends on [n]: SPI [=y] && SPI_MASTER [=y] && (ARCH_PHYTIUM || COMPILE_TEST [=n])
  Selected by [m]:
  - SPI_PHYTIUM_PLAT [=m] && SPI [=y] && SPI_MASTER [=y]
  - SPI_PHYTIUM_PCI [=m] && SPI [=y] && SPI_MASTER [=y] && PCI [=y]

Signed-off-by: WangYuli <[email protected]>
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SPI_PHYTIUM_PLATSPI_PHYTIUM_PCI配置项中添加了ARCH_PHYTIUM || COMPILE_TEST依赖条件,这可能会影响这些配置项在非Phytium架构上的可用性。需要确认这一改动是否符合设计要求。
  • 检查COMPILE_TEST是否是一个有效的编译测试条件,以及是否有相应的文档说明其用途。

是否建议立即修改:

  • 是,需要确保添加的依赖条件是必要的,并且不会对现有用户造成负面影响。同时,建议添加相应的文档说明以帮助其他开发者理解这一变更。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714 Avenger-285714 merged commit b852af2 into deepin-community:linux-6.6.y Aug 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants