Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: guangruntong: Drop common.mk build rules at Makefile #357

Merged

Conversation

Avenger-285714
Copy link
Collaborator

When exec "make clean" after "make distclean", here is follow errors:

drivers/net/ethernet/guangruntong/Makefile:30: *** Cannot find common.mk build rules. Stopped.

When exec "make clean" after "make distclean", here is follow errors:

drivers/net/ethernet/guangruntong/Makefile:30: *** Cannot find common.mk build rules. Stopped.

Signed-off-by: WangYuli <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign utsweetyfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了对 common.mk 文件存在性的检查,可能会导致未定义的变量错误,如果 common.mk 文件确实不存在。
  • 使用了 $(eval) 而不是 eval 函数来避免 SLES 10 SP4 的 Make 错误,这是一个好的做法,但应该确保所有使用 $(eval) 的代码都已经过测试。

是否建议立即修改:

  • 是,建议立即修改以避免潜在的构建错误。同时,应该确保所有使用 $(eval) 的代码都已经过测试,以确保其行为与预期一致。

@Avenger-285714 Avenger-285714 merged commit 81dbf1d into deepin-community:linux-6.6.y Aug 10, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants