Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm: amdgpu: radeon: disable cache flush workaround for LoongArch and Loongson64 #323

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

MingcongBai
Copy link
Contributor

This workaround causes instability for LoongArch/Loongson (MIPS) devices based on the 7A1000/2000 chipset under heavy I/O load.

FIXME: Disable this workaround until we find a better fix (possibly in the platform-specific PCI code).

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yukarichiba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FlyGoat
Copy link
Contributor

FlyGoat commented Jul 16, 2024

MACH_LOONGSON64 足以覆盖LA与MIPS的受影响平台了。

… Loongson64

This workaround causes instability for LoongArch/Loongson (MIPS) devices
based on the 7A1000/2000 chipset under heavy I/O load.

FIXME: Disable this workaround until we find a better fix (possibly in the
platform-specific PCI code).

Signed-off-by: Mingcong Bai <[email protected]>
@MingcongBai MingcongBai force-pushed the bai/linux-6.6.y/loongarch64-amdgpu-workaround branch from edce4eb to 8f09e0a Compare July 16, 2024 06:45
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在AMDGPU的ring_emit_fence_gfx函数中,新增了条件编译指令来禁用针对LoongArch/Loongson (MIPS) 7A1000/2000芯片组的workaround,这有助于解决在重负载下的不稳定问题。
  • 注释中提到“FIXME:禁用此workaround直到我们找到更好的解决方案(可能是在平台特定PCI代码中)”。这表明当前的workaround可能不是最优的,需要进一步探索解决方案。

是否建议立即修改:

  • 是,建议立即修改以避免潜在的系统不稳定问题。同时,需要关注注释中提到的“FIXME”,确保问题得到及时解决,以保护系统的稳定性。

@MingcongBai
Copy link
Contributor Author

MACH_LOONGSON64 足以覆盖LA与MIPS的受影响平台了。

了解,已据此修改

@opsiff opsiff merged commit 46ba4ef into linux-6.6.y Jul 16, 2024
5 of 9 checks passed
@MingcongBai MingcongBai deleted the bai/linux-6.6.y/loongarch64-amdgpu-workaround branch July 22, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants