Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "drm/nouveau/firmware: Fix SG_DEBUG error with nvkm_firmware_ctor() #314

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

MingcongBai
Copy link
Contributor

This commit fixes a kernel BUG (which ends up resulting in a hang) on a Lenovo ThinkBook 14 G4+ ARA with AMD + NVIDIA graphics.

This reverts commit 2a5599c.

…ctor()"

This commit fixes a kernel BUG (which ends up resulting in a hang) on a Lenovo
ThinkBook 14 G4+ ARA with AMD + NVIDIA graphics.

This reverts commit 2a5599c.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • nvkm_firmware_ctor函数中,fw->img的内存分配应该使用kmalloc而不是dma_alloc_coherent,以避免潜在的DMA错误。
  • dma_map_single函数的使用应该检查返回值,以确保内存映射成功。
  • kfree函数在内存映射失败时被调用,但是没有相应的注释说明为什么需要kfree
  • sg_init_one函数的使用应该确保fw->img的内存地址是正确的。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants