Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: device 0x15d8 don't use AMD_DPM_FORCED_LEVEL_* except AMD_DPM_FO… #305

Merged

Conversation

MingcongBai
Copy link
Contributor

…RCED_LEVEL_AUTO

Some devices have stablity issue on AMD_DPM_FORCED_LEVEL_* except AMD_DPM_FORCED_LEVEL_AUTO. Don't use these AMD_DPM_FORCED_LEVEL

Bug: https://pms.uniontech.com/bug-view-203541.html

Signed-off-by: hongao [email protected]
Change-Id: I84069c201713a4f86a3d492e35a86bd5f59b2d54 (cherry picked from commit 669fa93ed09c5c27233bc8ad0c9ba1a125ae4e96)

…RCED_LEVEL_AUTO

Some devices have stablity issue on AMD_DPM_FORCED_LEVEL_* except AMD_DPM_FORCED_LEVEL_AUTO.
Don't use these AMD_DPM_FORCED_LEVEL

Bug: https://pms.uniontech.com/bug-view-203541.html

Signed-off-by: hongao <[email protected]>
Change-Id: I84069c201713a4f86a3d492e35a86bd5f59b2d54
(cherry picked from commit 669fa93ed09c5c27233bc8ad0c9ba1a125ae4e96)
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yukarichiba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff
Copy link
Member

opsiff commented Jul 2, 2024

/ok-to-test

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的代码中,对pdev->device的检查使用了硬编码的设备ID,这可能不利于代码的可维护性和可扩展性。建议使用设备ID的常量或枚举类型。
  • 新增的警告信息中使用了pr_warn,这是一个旧式的打印函数,建议使用dev_errdev_info等更现代的日志函数。
  • 新增代码中直接访问pdev->device可能需要考虑是否有权限检查,以确保不会访问到非预期的设备信息。
  • 新增代码中直接返回-EINVAL,这是一个不具体的错误码,建议使用一个更具描述性的错误码,或者定义一个错误码常量。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants