[linux-6.6.y] Add support for Zhaoxin HW Random Number Generator #257
Conversation
zhaoxin inclusion category: feature ------------------- This driver provides kernel-side support for the Random Number Generator hardware found on Zhaoxin based motherboards. Signed-off-by: leoliu-oc <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @leoliu-oc. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
leoliu-oc
changed the title
|
|
||
| pr_info("VIA RNG detected\n"); | ||
| err = hwrng_register(&via_rng); | ||
| if (err) { | ||
| pr_err(PFX "RNG registering failed (%d)\n", | ||
| err); | ||
| pr_err(PFX "RNG registering failed (%d)\n", err); |
There was a problem hiding this comment.
这里修改的原因是，checkpatch.pl会提示格式warning。不过，这边会恢复保留原先格式。
| int err; | ||
|
|
||
| if (!x86_match_cpu(zhaoxin_rng_cpu_ids)) { | ||
| pr_err(PFX "The CPU isn't support XSTORE.\n"); |
There was a problem hiding this comment.
这里是参考同内核类似情况采用pr_err的。这边的理解是，要么使用pr_err，要么直接不打印任何信息。而改为pr_info的话，会导致在其他非zhaoxin_rng_cpu_ids列表中的处理器平台上会多出冗余打印信息。
|
/lgtm |
|
/ok-to-test |
deepin pr auto review关键摘要:
是否建议立即修改: |
zhaoxin inclusion
category: feature
This driver provides kernel-side support for the Random Number Generator hardware found on Zhaoxin based motherboards.