Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTx: phytium: Add Phytium INTx driver support #188

Merged

Conversation

tianwei08222
Copy link

Driver for Phytium PCIe legacy INTx interrupt controller.

Driver for Phytium PCIe legacy INTx interrupt controller.

Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Tian Wei <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zeno-sole for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_ixic_irq_eoi函数中,WARN_ON(intx >= NUM_IRQS);可能不会触发,因为intx03之间。应该添加对intx的检查,确保它不会大于等于NUM_IRQS
  • phytium_ixic_irq_alloc函数中的WARN_ON(nr_irqs != 1);可能会在nr_irqs不为1时触发,但nr_irqs的值在04之间,所以这个检查可能是多余的。
  • ioremap在打开maps时可能会失败,没有检查返回值,应该添加对ioremap返回值的检查。
  • of_address_to_resource函数的错误处理没有实现,如果解析资源失败,应该返回错误代码。
  • phytium_ixic_dt_init函数中的out_unmap块中没有处理iounmap的返回值,如果iounmap失败了,内存可能会泄漏。
  • phytium_ixic_acpi_probe函数中的out_unmap块中没有处理iounmap的返回值,如果iounmap失败了,内存可能会泄漏。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants