Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper translations for all chart source types #53

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jun 2, 2021

Before we were just stringifying the enum, which is not safe as the enum is now a number instead of a string.

Before we were just stringifying the enum, which is not safe as the enum is now a number instead of a string.
@mofojed mofojed added the bug Something isn't working label Jun 2, 2021
@mofojed mofojed added this to the June 2021 milestone Jun 2, 2021
@mofojed mofojed requested a review from niloc132 June 2, 2021 16:20
@mofojed mofojed self-assigned this Jun 2, 2021
@mofojed mofojed merged commit 6faade0 into deephaven:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants