Skip to content

Conversation

@vbabich
Copy link
Collaborator

@vbabich vbabich commented Jan 9, 2026

Fix header group calculation when child columns are scrolled out of the viewport. Fall back to calculated value before the theme default column width.

@vbabich vbabich changed the title DH-21367: Fix shifting header group text fix: DH-21367: Fix shifting header group text Jan 9, 2026
@vbabich vbabich self-assigned this Jan 9, 2026
@vbabich vbabich requested review from a team and bmingles and removed request for a team January 9, 2026 21:42
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.97%. Comparing base (7b2a23e) to head (aedbba3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/grid/src/GridRenderer.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
+ Coverage   45.71%   45.97%   +0.26%     
==========================================
  Files         771      771              
  Lines       43649    43650       +1     
  Branches    11046    11230     +184     
==========================================
+ Hits        19954    20069     +115     
+ Misses      23678    23536     -142     
- Partials       17       45      +28     
Flag Coverage Δ
unit 45.97% <50.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbabich vbabich enabled auto-merge (squash) January 9, 2026 21:55
@vbabich vbabich merged commit 1b517d6 into deephaven:main Jan 9, 2026
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants