Get console type from the API, don't allow switching language #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbabich
previously approved these changes
Jul 20, 2021
Collaborator
vbabich
left a comment
vbabich
left a comment
There was a problem hiding this comment.
Can getConsoleTypes potentially resolve with an empty array?
Member
Author
That's a good point. I'll add a case to handle that instead of assuming it's not empty. |
Fixes deephaven#58 - The server does not support switching languages, remove that functionality - Get the console types (languages) from the connection, use the first one as default
- Remove unused switchLanguages method - Initialize language to null
mofojed
force-pushed
the
58-language-select
branch
from
85bbaea to
2499c6f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58