Remove @JsMethod from JsTable and JsTreeTable features that do not currently work. #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Jul 29, 2021
mofojed
commented
- Related to Implement PartitionedTable, delete TableMap #37 and Column statistics #697, there is some table functionality that does not work yet.
- Comment out the methods that do not currently work (shouldn't have an API that doesn't work).
- UI checks for the presence of the method for whether to show the option or not. When they are added back, they should appear in the UI again. See Some table features are shown even though they do not work correctly web-client-ui#136
- Related to deephaven#37 and deephaven#697, there is some table functionality that does not work yet. - Comment out the methods that do not currently work (shouldn't have an API that doesn't work). - UI checks for the presence of the method for whether to show the option or not. When they are added back, they should appear in the UI again. See deephaven/web-client-ui#136
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this pull request
Jul 29, 2021
- Related to deephaven/deephaven-core#931 - Rollup, column statistics already checked if the methods existed, just needed to add the same check for totals
mofojed
changed the title
mofojed
added a commit
to deephaven/web-client-ui
that referenced
this pull request
Jul 30, 2021
- Related to deephaven/deephaven-core#931 - Rollup, column statistics already checked if the methods existed, just needed to add the same check for totals
niloc132
reviewed
Jul 30, 2021
Member
niloc132
left a comment
niloc132
left a comment
There was a problem hiding this comment.
Arguably you should also just kill the getTreeTable call, anything else that can return a TreeTable from the idesession?
| public Promise<JsTotalsTable> getTotalsTable(@JsOptional Object config) { | ||
| // TODO: #37: Need SmartKey support for this functionality | ||
| // @JsMethod | ||
| public Promise<JsTotalsTable> getTotalsTable(Object config) { |
Member
There was a problem hiding this comment.
that config is still optional, right?
| public Promise<JsTotalsTable> getTotalsTable(@JsOptional Object config) { | ||
| // TODO: #37: Need SmartKey support for this functionality | ||
| // @JsMethod | ||
| public Promise<JsTotalsTable> getTotalsTable(Object config) { |
- Don't bother touching JsTreeTable, client won't be able to retrieve one anyway - JsIgnore session.getTreeTable - Add JsOptionals back but commented out
niloc132
approved these changes
Jul 30, 2021
jmao-denver
pushed a commit
to jmao-denver/deephaven-core
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.