Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe-controversial ui improvements #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cosmicoptima
Copy link

i expect you to probably not merge, but if you don't, i'm curious as to why you prefer the current ui

@deepfates
Copy link
Owner

can you describe the differences or send a screenshot? main reason i haven't been updating this is I'm on a long trip abroad, don't feel like the UI is set in stone or anything. happy to hear your thoughts

@deepfates
Copy link
Owner

Okay I've pulled the changes and tried them. I think removing text-decoration is nice, especially since they have a hover background to indicate they're clickable.

I don't understand putting the similarity in the links though? It's already being indicated by the opacity of the links (is not obvious perhaps?) and it's available on hover as well. Plus cosine similarity is not super informative by itself, only in relation to the rest of the list which is already sorted. Seems like it adds more clutter than utility?

Happy to discuss it more though!

@cosmicoptima
Copy link
Author

yeah i didn't notice differences in opacity at all

@cosmicoptima
Copy link
Author

i thought one had to find out via hover

@deepfates
Copy link
Owner

Okay yea that is a problem for sure. Sometimes the similarity is more jagged and this is easier to see, but sometimes a lot of the links have really close similarity and it's not. Also I didn't really consider how different themes will work with this, probably some of them are much harder to tell opacity in. Thinking of other channels to dsiplay this infomation now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants