Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align all the records generated with latest schema #6

Merged
merged 38 commits into from
Mar 18, 2025
Merged

align all the records generated with latest schema #6

merged 38 commits into from
Mar 18, 2025
+1,183 −441

Conversation

TejasMorbagal
Copy link
Member

@TejasMorbagal TejasMorbagal commented Mar 12, 2025 •
edited
Loading

This PR includes the changes implemented to generate valid records which aligns with latest OSC-schema

Testing strategy:

  1. I have avoided complex mocking to have unit tests which are more maintainable.
  2. To test the publish feature, there is an option 'write_to_file' to allow generation of files locally.
  3. For integration test, we have a testing-repo to check if the files generated pass the validation checks.

@TejasMorbagal
current state
Loading
Loading status checks…
f78e7dd
@TejasMorbagal
introduced new constants and re-adding self-links
Loading
Loading status checks…
755c51e
@TejasMorbagal
fix updating var base catalog
Loading
Loading status checks…
3a962eb
@TejasMorbagal
refactored add themes as links
Loading
Loading status checks…
8647f45
@TejasMorbagal
refactor
Loading
Loading status checks…
3d2d68c
@TejasMorbagal
implemented ogc api record generation for workflow and experiment
Loading
Loading status checks…
1ab4461
@TejasMorbagal
implementation works to generate valid ogc api records for experiment…
Loading
Loading status checks…
d2591db 
…s and workflows
@TejasMorbagal
update github_automation class to fork only if local clone dir doesn'…
Loading
Loading status checks…
c883649 
…t exist, added write_to_file option for local testing during development
@TejasMorbagal
extract repeated logic into helper methods
Loading
Loading status checks…
5b403a1
@TejasMorbagal
refactor to remove comments
Loading
Loading status checks…
7769721
@TejasMorbagal
refactor to remove comments
Loading
Loading status checks…
9ae54f6
@TejasMorbagal
combined publish methods to create a single GitHub PR
Loading
Loading status checks…
03981a6
@TejasMorbagal
added lint with ruff to CI
Loading
Loading status checks…
adee40e
@TejasMorbagal
ruff lint checks
Loading
Loading status checks…
19c6b21
@TejasMorbagal
update cli command to publish all files in one PR
Loading
Loading status checks…
94a3452
@TejasMorbagal
updated ci to install ruff explicitly
Loading
Loading status checks…
7d7dc7d
@TejasMorbagal
updated ci
Loading
Loading status checks…
457813d
This was linked to issues Mar 12, 2025
Removal of osc:themes #4
Closed
Typo in target path specification for variables in OscDatasetStacGenerator #5
Closed
@TejasMorbagal TejasMorbagal added the enhancement New feature or request label Mar 12, 2025
@TejasMorbagal TejasMorbagal self-assigned this Mar 12, 2025
@TejasMorbagal TejasMorbagal marked this pull request as draft March 12, 2025 17:03
@TejasMorbagal
remove commented code
Loading
Loading status checks…
9b59656
@TejasMorbagal
remove commented code
Loading
Loading status checks…
556f1a0
@TejasMorbagal
update base catalogs of experiments and workflows
Loading
Loading status checks…
3722dc4
@TejasMorbagal
adapted to generated valid records
Loading
Loading status checks…
40dbd6a
@TejasMorbagal
refactor
Loading
Loading status checks…
dc1bc4b
@TejasMorbagal
updated unit tests
Loading
Loading status checks…
20f382a
@TejasMorbagal
formatting
Loading
Loading status checks…
4815567
@TejasMorbagal
fixed unit test
Loading
Loading status checks…
80cde90
@TejasMorbagal
few more uni tests
Loading
Loading status checks…
741e34b
@TejasMorbagal
code formated
Loading
Loading status checks…
b2b9394
@TejasMorbagal TejasMorbagal marked this pull request as ready for review March 14, 2025 14:27
@TejasMorbagal
clean up
Loading
Loading status checks…
b85e541
@TejasMorbagal TejasMorbagal requested a review from forman March 14, 2025 14:31
@TejasMorbagal
update README.md
Loading
Loading status checks…
3eaadd4
@TejasMorbagal
updated format string method to generate titles in a standard format
Loading
Loading status checks…
c17550d
@TejasMorbagal
black reformatted
Loading
Loading status checks…
69d4848
thomasstorm
thomasstorm requested changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@thomasstorm thomasstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md still refers to the old way. Please update that file accordingly.

@thomasstorm
Copy link
Collaborator

Looks good - I have added quite a lot of comments, but none of them are severe -- apart from the README.md update, which is necessary.

TejasMorbagal and others added 7 commits March 18, 2025 16:12
@TejasMorbagal
update README.md
Loading
Loading status checks…
8b29f13
@TejasMorbagal @thomasstorm
Update deep_code/utils/ogc_api_record.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
22aef9b 
Co-authored-by: Thomas Storm <thomas.storm@brockmann-consult.de>
@TejasMorbagal @thomasstorm
Update deep_code/utils/ogc_api_record.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
535a25a 
Co-authored-by: Thomas Storm <thomas.storm@brockmann-consult.de>
@TejasMorbagal
addressed suggestions to PR #6
Loading
Loading status checks…
dffe4f6
@TejasMorbagal
renamed clone_repository method to clone_sync_repository to better ma…
Loading
Loading status checks…
4bc32a6 
…tch the functionality
@TejasMorbagal
removed extra non-mandatory comments
Loading
Loading status checks…
3ae5a32
@TejasMorbagal
clean up
Loading
Loading status checks…
32068d8
@TejasMorbagal TejasMorbagal merged commit 43e3aea into main Mar 18, 2025
1 check passed
TejasMorbagal added a commit that referenced this pull request Mar 26, 2025
@TejasMorbagal
addressed suggestions to PR #6
fdb350d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasstorm thomasstorm

@forman forman

Assignees

@TejasMorbagal TejasMorbagal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in target path specification for variables in OscDatasetStacGenerator Removal of osc:themes
2 participants
@TejasMorbagal @thomasstorm