Skip to content

Commit

Permalink
Merge pull request #13 from deel-ai/chore/remove_numpy_version
Browse files Browse the repository at this point in the history
Update versions (requirements, tox, pre-commit hooks)

Versions of packages in multiple files have been updated:
- NumPy 1.19.5 has a vulnerability and must be avoided (https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-34141). The fixed version in requirements.txt is then removed to fetch the latest NumPy version.
- The tox virtual environments were fetching different torch/torchvision versions from the ones in requirements.txt. These versions are now aligned in both files to torch==1.10.2+cu113 and torchvision==0.11.3+cu113.
- The pre-commit hooks have been updated to retrieve the latest versions up to date. Note that black hook 21.6b0 was broken: an update was mandatory.
  • Loading branch information
cofri authored Jun 15, 2022
2 parents 3e3f598 + 9bd9956 commit e8c11cc
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/generic_bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ body:
options:
- Layers
- Activation functions
- Initializers
- Initializers
- Loss functions
- Normalizers
validations:
Expand Down
12 changes: 6 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,38 +19,38 @@

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.0.1
rev: v4.3.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
exclude: LICENSES/headers
- id: check-added-large-files

- repo: https://github.com/asottile/reorder_python_imports
rev: v2.6.0
rev: v3.1.0
hooks:
- id: reorder-python-imports

- repo: https://github.com/psf/black
rev: 21.6b0
rev: 22.3.0
hooks:
- id: black

- repo: https://github.com/pre-commit/mirrors-pylint
rev: v3.0.0a3
rev: v3.0.0a5
hooks:
- id: pylint
args: [--enable=unused-import --max-line-length=100, --disable=all]


- repo: https://github.com/commitizen-tools/commitizen
rev: v2.20.0
rev: v2.27.1
hooks:
- id: commitizen
stages: [commit-msg]

- repo: https://github.com/Lucas-C/pre-commit-hooks
rev: v1.1.10
rev: v1.2.0
hooks:
- id: insert-license
name: insert MIT license
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ work is not in vain.
- Clone the repo `git clone https://github.com/deel-ai/deel-torchlip.git`.
- Go to your freshly downloaded repo `cd deel-torchlip`
- Create a virtual environment and install the necessary dependencies for development:

`make prepare-dev && source torchlip_dev_env/bin/activate`.
- You are ready to install the library:

Expand Down
6 changes: 3 additions & 3 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ These management rules are intended to be collaborative and all those involved i

The governance committee is initially composed of DEEL members who contributed to the first version of `deel-torchlip` and are the only contributors to the master branch.

The governance committee is responsible for the master branch that contains the code of the version of the library that is officially recognised.
The governance committee is responsible for the master branch that contains the code of the version of the library that is officially recognised.

These governance committee members are the only ones able to merge pull requests into this branch which from contributions branches.

Expand All @@ -22,13 +22,13 @@ The governance committee identifies among the contributors who by their merits c

### Contributors

A contributor is anyone who comments any aspects relating to the project: comments on an issue or pull request, documentation, architecture, code and validation tests or anybody with a merged pull request.
A contributor is anyone who comments any aspects relating to the project: comments on an issue or pull request, documentation, architecture, code and validation tests or anybody with a merged pull request.

All governance committee membres are contributors.

### Maintainers

All contributors with write rights (commit rigths) are maintainers.
All contributors with write rights (commit rigths) are maintainers.

....

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
torch_testing==0.0.2
inflection==0.5.1
numpy==1.19.5
numpy
torch==1.10.2+cu113
torchvision==0.11.3+cu113
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ pip_version = pip>=20
deps =
pytest
torch_testing
torch==1.7.0+cpu
torchvision==0.8.1+cpu
torch==1.10.2+cu113
torchvision==0.11.3+cu113
install_command = pip install --find-links https://download.pytorch.org/whl/torch_stable.html {opts} {packages}
commands =
pytest tests
Expand Down

0 comments on commit e8c11cc

Please sign in to comment.