finish polygon #2431

buck54321 · 2023-07-10T00:12:03Z

Generalize the Ethereum wallet and server backend. Prepare getgas utility and RPC compatibility testing. Add tokens to Polygon harness and get gas estimates. Update some front end token-related code. Deploy USDC swap contract for Polygon mainnet and get gas estimates. Update simnet trade tests.

chappjc

How do you use deploy? Where do you send the fee gwei? The deploy docs refer to "the wallet", but what wallet? Does this require a dexc assetdb wallet for the asset? I've used remix with web3 injection to deploy things as needed previously, so it's entirely independent.

Why is deploy.go in cleint/asset/eth instead of client/asset/eth/cmd/deploy? That seems wrong. If you want it reusable from tools other than cmd/deploy, maybe it should be in client/asset/eth/deploy. Seems like it's just polluting client/asset/eth like it is currently.

The deploy binary is checked in.

buck54321 · 2023-07-10T12:07:31Z

How do you use deploy?

Instructions for using deploy are at the top of client/asset/eth/cmd/deploy/main.go.

Where do you send the fee gwei? The deploy docs refer to "the wallet", but what wallet? Does this require a dexc assetdb wallet for the asset?

See IMPORTANT: at the top of deploy/main.go. deploy uses the same wallet credentials as getgas. It offers similar auxiliary functions to getgas for estimating funding requirements and returning balance.

I've used remix with web3 injection to deploy things as needed previously, so it's entirely independent.

What's the benefit of it being entirely independent? Is "web3 injection" just a webpage using the provider API by bouncing through a wallet extension? That's what is seems to say here.

Does Remix offer any advantages? I'm not sure how etherscan gets the metadata associated with the contract. For instance, here is the ethereum mainnet swap contract. How do they get the source code and ABI info? Does Remix do that?

Why is deploy.go in cleint/asset/eth instead of client/asset/eth/cmd/deploy?

I can move it if you'd rather I export some stuff.

buck54321 · 2023-07-10T12:14:15Z

client/asset/eth/cmd/getgas/README.md

@@ -8,7 +8,7 @@ If this is a new asset, you must populate either `dexeth.VersionedGases` or
 `dexeth.Tokens` with generous estimates before running `getgas`.

 ### Use
- Create a credentials file. `getgas` will look in `~/ethtest/getgas-credentials.json`. You can override that location with the `--creds` CLI argument. The credentials file should have the JSON format in the example below. The seed can be anything.
+- Create a credentials file. `getgas` will look in `~/ethtest/getgas-credentials.json` for Ethereum, and `~/ethtest/getgas-credentials_polygon.json` for Polygon. You can override that location with the `--creds` CLI argument. The credentials file should have the JSON format in the example below. The seed can be anything.


I actually want to combine these into one file and move everything from ethtest somewhere under dextest.

OK if I do this now and screw up all of your credentials files?

dex/networks/polygon/params.go

dex/testing/polygon/harness.sh

buck54321 · 2023-07-10T12:35:43Z

dex/networks/erc20/contracts/updatecontract.sh

-sed -i.tmp "s/TEST_TOKEN=.*/TEST_TOKEN=\"${TEST_TOKEN_BYTECODE}\"/" ../../../testing/eth/harness.sh
-# mac needs a temp file specified above.
-rm ../../../testing/eth/harness.sh.tmp
+for HARNESS_PATH in "$(realpath ../../../testing/eth/harness.sh)" "$(realpath ../../../testing/polygon/harness.sh)"; do


Not super crazy about this solution. This pastes the exact same byte code into both harnesses, so perhaps some room for de-duplication.

chappjc · 2023-07-10T13:58:16Z

Why is deploy.go in cleint/asset/eth instead of client/asset/eth/cmd/deploy?

I can move it if you'd rather I export some stuff.

Don't bother. I'd rather have some new tangential stuff in client/asset/eth (ContractDeployer) than unnecessary exports.

Everything is fine, no need to change anything. For the sake of discussion though:

How do you use deploy?

Instructions for using deploy are at the top of client/asset/eth/cmd/deploy/main.go.

I had read that entire block comment, but didn't read into get gas. Sorry.

I've used remix with web3 injection to deploy things as needed previously, so it's entirely independent.

What's the benefit of it being entirely independent?

I mainly mentioned that approach to explain why the proposed tool gave me pause. However, reasons why I personally prefer an approach for contract deployment that is separate:

(1) It's already available. We don't have to make the package modifications and trade-offs above. (2) It's interactive from compilation to deployment. At a glance, I can't tell what compiled runtime bytecode deploy/main.go is going to deploy. (It's the Bin in the pre-generated contract.go). When I deploy a contract interactively, I be sure to set the solc version and optimization iterations, make sure it didn't have any warnings etc., enter the target erc20 address, set and sanity-check the fees. (3) I use the wallet of my choice to deploy (something with no other purpose than being a "deployer", although I now see that getgas-credentials.json makes it somewhat separate although likely to be derived from a dex wallet seed)

Does Remix offer any advantages? I'm not sure how etherscan gets the metadata associated with the contract. For instance, here is the ethereum mainnet swap contract. How do they get the source code and ABI info? Does Remix do that?

You upload the source to etherscan manually. Remix isn't related to that from what I recall. When you upload, you specify the same solc build config (version and opt iterations) used when building the contract's bin.

martonp

Regarding deployment, why don't we just use hardhat?
I've used it in #2223 to do testing. It's nice because it allows you to directly test the smart contract without worrying about anything else. You can also deploy with it.
https://hardhat.org/

client/asset/polygon/polygon.go

dex/testing/polygon/harness.sh

martonp · 2023-07-11T09:41:38Z

client/asset/eth/multirpc.go

 			ctx, cancel := context.WithTimeout(ctx, defaultRequestTimeout)
 			err := t.f(ctx, p)
 			cancel()
 			if err != nil {
-				return fmt.Errorf("RPC Provider @ %q has a non-compliant API: %v", p.host, err)
+				return fmt.Errorf("%s: RPC Provider @ %q has a non-compliant API: %v", t.name, p.host, err)


I see this error log in the node after the compatibility test.. I guess the connection is not being closed properly after the tests. Probably nbd though.

What were you running when you saw this message? dexc or a test?

client/asset/eth/cmd/deploy/deploy

dex/testing/polygon/harness.sh

client/asset/eth/eth.go

dex/networks/polygon/params.go

chappjc · 2023-07-19T21:13:06Z

Any suggested Polygon RPC providers? Every single one at https://github.com/decred/dcrdex/wiki/Ethereum#rpc-provider-list-partial have Polygon endpoints, but I wondered if you has success with any.

chappjc · 2023-07-19T21:17:00Z

https://rpc.ankr.com/polygon_mumbai is probably fine although no ws
https://polygon-mumbai-bor.publicnode.com too

buck54321 · 2023-07-20T19:45:32Z

Alchemy is definitely working. I think I was having problems with Infura and Rivet. I need to do some testing with those.

chappjc

Basic wallet functionality for MATIC and USDC worked well after enabling usdc.polygon (see comments and diffs).

Tested Mumbai (testnet) wallet with blast and alchemy endpoints w/ api keys, but here are some public endpoints that could work:

https://polygon-mumbai-bor.publicnode.com
https://polygon-mumbai.blockpi.network/v1/rpc/public
https://rpc-mumbai.polygon.technology
https://endpoints.omniatech.io/v1/matic/mumbai/public
wss://polygon-testnet.public.blastapi.io
https://rpc.ankr.com/polygon_mumbai

(fine, although above it doesn't mention polygon or overlay the logo; an overlay might be too small anyway)

I configured MATIC on dex-test.ssgen.io (testnet), but did not test any trades with MATIC, only setup the endpoints and confirmed it would start. Next, I will test a MATIC trade, and then enable USDC.POLYGON on server.

I used these on the testnet server (only the first needs an apikey):

wss://polygon-mumbai.blockpi.network/v1/ws/<apikey>
wss://polygon-testnet.public.blastapi.io
https://polygon-mumbai.blockpi.network/v1/rpc/public
https://polygon-mumbai-bor.publicnode.com
https://rpc.ankr.com/polygon_mumbai

client/asset/polygon/polygon.go

server/asset/eth/eth.go

server/asset/polygon/polygon.go

chappjc · 2023-07-21T23:07:01Z

I suppose the following should say "MATIC" instead of "POLYGON":

Settled fine!

chappjc · 2023-07-21T23:09:53Z

Another MATIC vs. POLYGON that I noticed:

(right)

(wrong)

Probably also this:

JoeGruffins

Working well for me.

One thing I noticed on order history, symbols not there, does it look like this for others?

JoeGruffins · 2023-07-19T11:22:36Z

dex/testing/eth/harness.sh

+
+# DRAFT NOTE: Why are we doing this token send to nowhere?
 TOKEN_SEND_AMT=5000
 echo "Sending 5000 dextt.eth to testing."
 "./sendTokens" "${SIMNET_TOKEN_ADDRESS}" "${TOKEN_SEND_AMT}"


Probably the simnet tests?

I can't find a reference to the SIMNET_TOKEN_ADDRESS anywhere.

It's the address made by the seed in the ./simnet-setup.sh script so we have funds for trading immediately.

JoeGruffins · 2023-07-19T11:24:35Z

dex/testing/polygon/harness.sh

+echo "ERC20 SWAP contract address is ${ERC20_SWAP_CONTRACT_ADDR}. Saving to ${NODES_ROOT}/erc20_swap_contract_address.txt"
+cat > "${NODES_ROOT}/erc20_swap_contract_address.txt" <<EOF
+${ERC20_SWAP_CONTRACT_ADDR}
+EOF



You commented that mining is wonky is that why no 15 second mining session? If possible can add like the other harnesses?

Trying it out. Reduced min NUM for mine-alpha script to 1 too, So hopefully that helps.

client/asset/eth/deploy.go

chappjc · 2023-07-22T14:34:38Z

One thing I noticed on order history, symbols not there, does it look like this for others?

Same here. All the symbols are missing.

In the browser console I see 404s to the generic coin letter images, also upper case, which breaks their loading although we don't want the generic ones anyway:

client/webserver/site/src/js/orders.ts

chappjc · 2023-07-22T14:43:34Z

dex/bip-id.go

@@ -479,7 +479,7 @@ var bipIDs = map[uint32]string{
 	890:   "xsel",
 	900:   "lmo",
 	916:   "meta",
-	966:   "matic",
+	966:   "polygon", // changed from "matic"


I wonder if we should keep it here as "matic", since our bipIDs maps ID to symbol, not coin name.

This npm package addressed it by mapping to both symbol and coin name. https://github.com/bitcoinjs/bip44-constants#readme
Although I suppose it doesn't really matter if we just use the correct fields from UnitInfo...

The problems we're seeing are all places where we we're using symbol and we should have been using conventional unit. I like this change particularly because it brings those mistakes to the surface.

norwnd · 2023-07-23T09:26:24Z

Perhaps for token deposit/send views it would be nice to display which Blockchain was chosen (when user clicked deposit/send button), so that user doesn't accidentally send from Ethereum blockchain to Polygon (or vice versa):

Another thing to consider: currently I'm guessing Polygon and Ethereum private keys are different resulting in different addresses for each; while it's better from security perspective, is it really worth it ? Pretty much all exchanges I can remember give the user that impression that addresses across "similar" blockchains match.

buck54321 · 2023-07-25T20:27:48Z

NOTICES

1) For anyone who has used getgas, deploy, or anyone that has run nodeclient_harness_test.go on testnet

I have consolidated all of these credientials-file-based wallets into a single file at ~/dextest/credentials.json. See the getgas README for the format. The ~/ethtest directory is no longer used for anything, nor are the ~/ethtest/testnet-credentials.json, ~/ethtest/getgas-credentials.json, ~/ethtest/getgas-credentials_polygon.json, ~/ethtest/providers.json, or ~/ethtest/providers_polygon.json files.

Sorry if this causes some work for you, but the old scheme was getting out of hand.

2) For anyone who has sent funds to a testnet or mainnet Polygon wallet

As per @norwnd's suggestion, I have made changes such that all account-based assets will use the same seed, so will derive the same key and address.

martonp

Tested trading on both Infura and Alchemy.. working well.
One time on Infura I saw some crazy amount of confirmations:

it stagnated a bit and there was an error:

2023-08-08 10:17:44.487 [ERR] CORE: dex-test.ssgen.io:7232 tick: {redeemMatches order 85593c2ba1401832961278403497233287980a1cdd519dcb3fe17432095fb6cd - {error sending redeem transaction: error getting balance in excessive gas fee recovery: pending balance error: balance undeflow detected. pending out (134900000000000000) > balance (61809836994177172)}}

Then it eventually resolved itself. Looks like a uint32 underflow on the confirmations. It worked fine every other time.

On the wallets page the icons look like this.

It would be better if this was sorted so that the base chain comes first, and then all of its tokens listed below. I think ideally only the token would be listed on the sidebar and then within the token section you would see each of the networks it is on and your balance on each network.

Also, I see "polygon" written in some places and "matic" in others. I think it should be matic everywhere other than the "Token on Polygon" message.

client/asset/eth/chaincfg.go

client/asset/polygon/polygon.go

client/core/core.go

buck54321 · 2023-08-16T23:42:59Z

It would be better if this was sorted so that the base chain comes first, and then all of its tokens listed below. I think ideally only the token would be listed on the sidebar and then within the token section you would see each of the networks it is on and your balance on each network.

I agree.. Mind if I save it for a separate, dedicated effort.

martonp · 2023-08-22T12:10:48Z

I still see polygon instead of matic in the following places.

Also, token icons are messed up on the orders page:

martonp · 2023-08-22T12:11:58Z

Overall LGTM.. I'll test a bit more still on testnet.

martonp · 2023-08-27T10:43:43Z

I'm able to do both matic and polygon usdc swaps on testnet. On the orders page, the block explorer links for polygon token transactions do not work.

Generalize the ethereum wallet. Add tokens. Implement rpc tests and getgas. Server backend. Deploy usdc, Some frontend.

buck54321 · 2023-09-06T21:05:56Z

Updated the free server list and upped the defaultGasFeeLimit. Tested on mainnet.

chappjc reviewed Jul 10, 2023

View reviewed changes

buck54321 commented Jul 10, 2023

View reviewed changes

martonp reviewed Jul 11, 2023

View reviewed changes

ukane-philemon reviewed Jul 16, 2023

View reviewed changes

client/asset/eth/cmd/deploy/deploy Outdated Show resolved Hide resolved

buck54321 force-pushed the more-polygon branch from 713c0c4 to b221b4c Compare July 17, 2023 10:27

chappjc reviewed Jul 17, 2023

View reviewed changes

dex/testing/polygon/harness.sh Outdated Show resolved Hide resolved

chappjc reviewed Jul 17, 2023

View reviewed changes

client/asset/eth/eth.go Outdated Show resolved Hide resolved

chappjc reviewed Jul 17, 2023

View reviewed changes

dex/networks/polygon/params.go Show resolved Hide resolved

buck54321 force-pushed the more-polygon branch from b221b4c to 639408f Compare July 18, 2023 00:31

chappjc requested changes Jul 21, 2023

View reviewed changes

client/asset/polygon/polygon.go Outdated Show resolved Hide resolved

server/asset/eth/eth.go Show resolved Hide resolved

server/asset/polygon/polygon.go Outdated Show resolved Hide resolved

server/asset/polygon/polygon.go Show resolved Hide resolved

JoeGruffins approved these changes Jul 22, 2023

View reviewed changes

chappjc reviewed Jul 22, 2023

View reviewed changes

client/webserver/site/src/js/orders.ts Outdated Show resolved Hide resolved

chappjc reviewed Jul 22, 2023

View reviewed changes

buck54321 force-pushed the more-polygon branch 2 times, most recently from 606116a to cfe1998 Compare July 23, 2023 02:57

buck54321 force-pushed the more-polygon branch from 8e3b693 to 510af0e Compare July 25, 2023 20:27

buck54321 force-pushed the more-polygon branch from eb31d48 to 75376c3 Compare July 26, 2023 00:43

norwnd mentioned this pull request Aug 2, 2023

Add new assets to footer decred/dexweb#39

Merged

buck54321 force-pushed the more-polygon branch from dfa9646 to 39e973f Compare August 6, 2023 12:04

martonp reviewed Aug 8, 2023

View reviewed changes

client/asset/eth/chaincfg.go Outdated Show resolved Hide resolved

client/asset/polygon/polygon.go Outdated Show resolved Hide resolved

client/core/core.go Show resolved Hide resolved

buck54321 force-pushed the more-polygon branch from 39e973f to 09635cc Compare August 16, 2023 23:41

buck54321 force-pushed the more-polygon branch from 09635cc to b580448 Compare August 24, 2023 23:50

buck54321 force-pushed the more-polygon branch 2 times, most recently from 49c1a14 to c179cc0 Compare August 28, 2023 01:03

buck54321 and others added 19 commits September 6, 2023 12:19

Finish Polygon

9776557

Generalize the ethereum wallet. Add tokens. Implement rpc tests and getgas. Server backend. Deploy usdc, Some frontend.

try a different mining script

dc22f8e

add MATIC contracts. enable token returns

a4ca4d5

review followup

eca0e36

polygon usdc and log fixes

7c5eab4

review followup

4239952

parent network on new wallet for for tokens

2163ed7

consolidate credentials

757277d

longer defaultRequestTimeout. conccurent provider connection

710cb33

all account-based assets use same seed extension

755bfcd

cleanup ethtest directory stuff

f1c342d

add parent info to send and deposit forms

197f743

no genesis step needed

2a54235

fix gas limit calcs

d1a937c

check free testnet servers

4094a91

martonp review followup

9a4977c

fix token links

6fd97eb

update free server list

9cf2895

mainnet tested. ready

c8a9362

buck54321 force-pushed the more-polygon branch from ff33631 to c8a9362 Compare September 6, 2023 21:02

buck54321 merged commit 3fe9316 into decred:master Sep 6, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

finish polygon #2431

finish polygon #2431

buck54321 commented Jul 10, 2023

chappjc left a comment •

edited

Loading

buck54321 commented Jul 10, 2023 •

edited

Loading

buck54321 Jul 10, 2023

buck54321 Jul 23, 2023

buck54321 Jul 10, 2023

chappjc commented Jul 10, 2023 •

edited

Loading

martonp left a comment

martonp Jul 11, 2023

buck54321 Jul 17, 2023

martonp Jul 17, 2023

chappjc commented Jul 19, 2023

chappjc commented Jul 19, 2023 •

edited

Loading

buck54321 commented Jul 20, 2023

chappjc left a comment

chappjc commented Jul 21, 2023

chappjc commented Jul 21, 2023

JoeGruffins left a comment

JoeGruffins Jul 19, 2023

buck54321 Jul 22, 2023

JoeGruffins Jul 24, 2023 •

edited

Loading

JoeGruffins Jul 19, 2023

buck54321 Jul 23, 2023

chappjc commented Jul 22, 2023

chappjc Jul 22, 2023

buck54321 Jul 22, 2023 •

edited

Loading

norwnd commented Jul 23, 2023 •

edited

Loading

buck54321 commented Jul 25, 2023 •

edited

Loading

martonp left a comment

buck54321 commented Aug 16, 2023

martonp commented Aug 22, 2023

martonp commented Aug 22, 2023

martonp commented Aug 27, 2023

buck54321 commented Sep 6, 2023

finish polygon #2431

finish polygon #2431

Conversation

buck54321 commented Jul 10, 2023

chappjc left a comment • edited Loading

Choose a reason for hiding this comment

buck54321 commented Jul 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc commented Jul 10, 2023 • edited Loading

martonp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc commented Jul 19, 2023

chappjc commented Jul 19, 2023 • edited Loading

buck54321 commented Jul 20, 2023

chappjc left a comment

Choose a reason for hiding this comment

chappjc commented Jul 21, 2023

chappjc commented Jul 21, 2023

JoeGruffins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins Jul 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc commented Jul 22, 2023

Choose a reason for hiding this comment

buck54321 Jul 22, 2023 • edited Loading

Choose a reason for hiding this comment

norwnd commented Jul 23, 2023 • edited Loading

buck54321 commented Jul 25, 2023 • edited Loading

NOTICES

1) For anyone who has used getgas, deploy, or anyone that has run nodeclient_harness_test.go on testnet

2) For anyone who has sent funds to a testnet or mainnet Polygon wallet

martonp left a comment

Choose a reason for hiding this comment

buck54321 commented Aug 16, 2023

martonp commented Aug 22, 2023

martonp commented Aug 22, 2023

martonp commented Aug 27, 2023

buck54321 commented Sep 6, 2023

chappjc left a comment •

edited

Loading

buck54321 commented Jul 10, 2023 •

edited

Loading

chappjc commented Jul 10, 2023 •

edited

Loading

chappjc commented Jul 19, 2023 •

edited

Loading

JoeGruffins Jul 24, 2023 •

edited

Loading

buck54321 Jul 22, 2023 •

edited

Loading

norwnd commented Jul 23, 2023 •

edited

Loading

buck54321 commented Jul 25, 2023 •

edited

Loading