Full node support for Dash #2424
Conversation
|
Why the new pr? |
My fork github repo was messed up .. |
There was a problem hiding this comment.
I'm still not sure about the Firo ports change, but everything else looks good to me.
I still see the error, when applying #2425 [ERR] CORE[dash]: error unlocking spent coins: rawrequest (lockunspent) error: -8: Invalid parameter, expected unspent output
It looks to me like the output is already spent from the point of view of the node before we call unlock. While we should figure out what's going on there, it doesn't look like a real problem to me, just a difference between bitcoind and dashd. The coins should be spent by that time by the split tx, but bitcoind does not remove them from the locked list automatically while dashd does maybe? Not sure.
8888 .. Firo is Asian and 8888 is prosperity ;-) |
I went into this deeper: In some cases I do actually see 'wrong' coins returned by the dex logic occasionally. Meaning they are not in the |
There was a problem hiding this comment.
Hmm. I'm not sure how this file ended up here. You can drop this file and its containing directory.
There was a problem hiding this comment.
Done
This is a side effect of this pr and directly running Dex code that asks for an address from inside the git code tree. In this case client/asset/dash/regnet_test.go.
I usually remember to clean up and did put in a pr to hide these directories from git but the granularity of the .gitignore is kinda unknown .. is it any code? I certainly see with other client asset tests.
Perhaps we should at least .gitignore any regtest/ directory above a certain height in the code tree. But what should be that height is not obvious.
There was a problem hiding this comment.
This is a side effect of this pr and directly running Dex code that asks for an address from inside the git code tree. In this case
client/asset/dash/regnet_test.go.
That file doesn't seem to exist. You can give steps to reproduce these misplaced files?
There was a problem hiding this comment.
Sequence
- Start Firo harness
cd dex/testing/firo
#export PATH to firod/firo-cli
./harness.sh- run asset tests
cd client/asset/firo
# delete any regtest dir if found
go test -v -count=1 -tags=harness ./...You should see a new directory regtest if the livetest code was successful
There was a problem hiding this comment.
dev@dev-ThinkPad-T430 ~/dex/dcrdex/client/asset/firo (harness_mining)$ ls
firo.go regnet_test.go
dev@dev-ThinkPad-T430 ~/dex/dcrdex/client/asset/firo (harness_mining)$ go test -v -count=1 -tags=harness ./...
=== RUN TestWallet
livetest.go:197: Setting up alpha/beta/gamma wallet backends...
2023-07-21 00:56:01.266 [DBG] TEST[alpha.alpha][RPC]: Node at 127.0.0.1:53768 reports subversion "/Satoshi:0.14.12.1/"
2023-07-21 00:56:01.302 [INF] TEST[alpha.alpha]: Connected wallet with current best block 3dc04a8987a951ae30bf7ce89653ae873ef1fd4d12b219b7160080b39bbd7d1d (352)
peer count = 3, err = <nil>2023-07-21 00:56:01.303 [DBG] TEST[beta.beta][RPC]: Node at 127.0.0.1:53769 reports subversion "/Satoshi:0.14.12.1/"
. . .
rate = 100, actual fee rate = 100 (22500 for 225 bytes), change = true
2023-07-21 00:56:04.972 [INF] TEST: Withdrew with a9a9f48aa475e4482be4e34919eb8370b57915b2f27940eb69a63550314ad421:0
--- PASS: TestWallet (3.71s)
=== RUN TestFetchExternalFee
#### External fee rate fetched:: 1 sat/B
--- PASS: TestFetchExternalFee (0.91s)
PASS
ok decred.org/dcrdex/client/asset/firo 4.632s
dev@dev-ThinkPad-T430 ~/dex/dcrdex/client/asset/firo (harness_mining)$ ls
firo.go regnet_test.go regtest
dev@dev-ThinkPad-T430 ~/dex/dcrdex/client/asset/firo (harness_mining)$
dev-warrior777
force-pushed
the
dash
branch
3 times, most recently
from
7d96f33
to
73b7ee9
Compare
|
Remember not to sync with master by merging into your feature branch. Please rebase. You may squash away all but one commit at this point, and that might be necessary to eliminate the merge commit. |
|
Just needs a rebase and a cache buster update. |
Full node support for Dash
original pr