dexc-desktop: Use macdrive for Darwin #2372

ukane-philemon · 2023-05-25T19:43:27Z

Builds on #2333.

I researched other options and MacDrive seem to be a reasonable option. It allows using supported native Mac APIs, which covers our use case.

I was able to implement some "native" macOS app behaviour and features; keeping the app running without windows, creating new windows, and having a dock icon menu.

I'm putting this up so we can have discussions around it and clarify what feature is missing (menu items etc)

EDIT: If we want to keep the New Window menu as @martonp mentioned here #2333 (comment), we'd have to allow more than one window on macOS.

client/cmd/dexc-desktop/app_darwin.go

ukane-philemon · 2023-05-27T01:57:32Z

Changes included in 638752b

Support for multiple windows (max: 5. this is not really a requirement just keeping things sane?)

Systray display.

martonp

Looking good.. personally I don't see any reason for multiple windows, but it's fine.

The scrollbar issue that was happening earlier is back again:

client/cmd/dexc-desktop/app_darwin.go

martonp · 2023-05-28T10:26:03Z

The top-left menu should have the same options as the dock icon menu:

ukane-philemon · 2023-05-28T20:27:25Z

The scrollbar issue that was happening earlier is back again:

When? I know some CSS styling is not supported on Webkit. Even some "default" styling in other browsers could also be missing.

EDIT: I'm unable to reproduce, tried building the CSS files again? :

scroll.mp4

EDIT 2: I notice the white bg on hover. @martonp what did you expect?

client/cmd/dexc-desktop/app_darwin.go

ukane-philemon · 2023-05-31T15:20:51Z

The top-left menu should have the same options as the dock icon menu:

Getting this to work as expected with native APIs was a PITA but it works.

As a bonus, I was able to get this working too (the nice check and window icon):

ukane-philemon · 2023-06-01T18:54:42Z

Rebased..

martonp · 2023-06-03T14:35:31Z

The scrollbar issue that was happening earlier is back again:

When? I know some CSS styling is not supported on Webkit. Even some "default" styling in other browsers could also be missing.

EDIT: I'm unable to reproduce, tried building the CSS files again? :

scroll.mp4
EDIT 2: I notice the white bg on hover. @martonp what did you expect?

Seems OK now.. maybe it's an intermittent issue or I didn't build it properly. But the build script builds the UI every time..

ukane-philemon · 2023-06-03T15:23:16Z

But the build script builds the UI every time..

Yup, that was why I did this #2333 (comment) earlier since I'd have to build several times to test everything was fine when working on that PR.

buck54321

We never shut down on Mac?

Window is not opening for me after installation. Logs show that dexc is shutting down right away.

...
2023-06-09 22:18:47.663 [INF] CORE: Connected to 1 of 1 DEX servers
2023-06-09 22:18:47.663 [INF] CORE: Loaded btc wallet configuration.
2023-06-09 22:18:47.663 [INF] CORE: Loaded dcr wallet configuration.
2023-06-09 22:18:47.663 [INF] CORE: Loaded 0 active orders.
2023-06-09 22:18:47.663 [INF] CORE: Loaded 0 active match orders
2023-06-09 22:18:47.663 [DBG] CORE: starting fiat rate fetching
2023-06-09 22:18:47.663 [DBG] WEB: Using embedded site resources.
2023-06-09 22:18:47.663 [INF] WEB: Using language en-US
2023-06-09 22:18:47.663 [INF] WEB: Using embedded HTML templates
2023-06-09 22:18:47.679 [DBG] APP: Exiting dexc main.

client/cmd/dexc-desktop/app_darwin.go

client/cmd/dexc-desktop/app.go

ukane-philemon · 2023-06-10T00:01:35Z

Window is not opening for me after installation. Logs show that dexc is shutting down right away.

Weird. I wonder what could be terminating dexc-desktop instance on your machine.

ukane-philemon · 2023-06-10T00:04:43Z

We never shut down on Mac?

If you mean automatically(i.e. after all windows have been closed and no active order), no. The user will have to shut down dexc-desktop on macOS using the Quit menu item or use Command+Q.

buck54321

Working well. Almost ready, imo.

External links are not functional for me.

client/cmd/dexc-desktop/app_darwin.go

ukane-philemon · 2023-06-23T18:15:42Z

Working well. Almost ready, imo.

I'm glad, you were able to test this PR and it's running fine on your end. I will look into the issue with the links.

martonp · 2023-06-24T06:08:33Z

In the "Window" section of the top toolbar, there are options for tabs, i.e. "Show Tab Bar", "Show Previous Tab". Is it possible to get rid of those?

ukane-philemon · 2023-06-25T18:32:06Z

In the "Window" section of the top toolbar, there are options for tabs, i.e. "Show Tab Bar", "Show Previous Tab". Is it possible to get rid of those?

Yeah, it is possible. I looked into it over the weekend.

Signed-off-by: Philemon Ukane <[email protected]>

- Add support for upto 5 windows for macOS. - Add icon to system status bar. - Add more webview config preferences. - Refactor. Signed-off-by: Philemon Ukane <[email protected]>

- Handle defer statements properly for darwin. - Remove syncserver for darwin - Refactor - Prevent multiple dexc-desktop instance. Signed-off-by: Philemon Ukane <[email protected]>

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon · 2023-07-07T23:43:51Z

Rebased for 36a9a1a.

Signed-off-by: Philemon Ukane <[email protected]>

chappjc · 2023-07-10T14:46:25Z

This looks A-OK to me. I'm unlikely to get a Mac to test anytime soon, so please decide when it's good to merge @buck54321 and pull the trigger when you like.

ukane-philemon · 2023-07-10T14:59:45Z

This looks A-OK to me. I'm unlikely to get a Mac to test anytime soon, so please decide when it's good to merge @buck54321 and pull the trigger when you like.

I am yet to push changes relating to the recent reviews but the major changes I'd like to add here are:

Getting external links to open in the user's default browser.
Enabling file uploads. (Figured out this wasn’t working while testing but has been a real PITA. I've implemented the required handlers/methods but still getting panics): Related documentations:
Doc 1, Doc 2 and Docs 3
Refactoring mainCore because it now looks too stuffy and long.

chappjc · 2023-07-10T15:27:18Z

2. Enabling file uploads. (Figured out this wasn’t working while testing but has been a real PITA. I've implemented the required handlers/methods but still getting panics)

Uploads? For the wallet config file and dex cert file selections? Do they not work?

ukane-philemon · 2023-07-10T16:06:00Z

Uploads? For the wallet config file and dex cert file selections? Do they not work?

Yes, they won't work unless we implement a special method for that.

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon · 2023-07-15T20:46:34Z

@chappjc, @buck54321, @martonp, blockers mentioned in #2372 (comment) have been addressed in my recent commits(i.e 3f1052d).

Signed-off-by: Philemon Ukane <[email protected]>

- Implement self-signed cert challenge handler for MacOS app Signed-off-by: Philemon Ukane <[email protected]>

buck54321

Nice work @ukane-philemon. I've confirmed that links and file uploads work.

I noticed that when I open the app, the window opens but doesn't take focus. Anybody else seeing this? I thought it was working before.

ukane-philemon · 2023-07-17T08:34:03Z

I noticed that when I open the app, the window opens but doesn't take focus. Anybody else seeing this? I thought it was working before.

I've just looked into this and I don't know how we can make the login form take focus automatically in NSWindow. We already use makeKeyAndOrderFront:, and I think that's all we need. Users might need to interact with the form before entering their password.

ukane-philemon · 2023-07-17T09:28:48Z

After poking around I found out we can achieve that behaviour with [[NSRunningApplication currentApplication] activateWithOptions:(NSApplicationActivateAllWindows | NSApplicationActivateIgnoringOtherApps)]; but it is discouraged in the Apple docs: You should rarely pass this flag because stealing key focus produces a poor user experience. See: https://developer.apple.com/documentation/appkit/nsapplicationactivationoptions/nsapplicationactivateignoringotherapps?language=objc

But IMO, I think we should enable this behaviour. Saves users the extra burden of interacting with the app. After all, they opened it and intend to use it. What do you think @buck54321?

chappjc reviewed May 26, 2023

View reviewed changes

client/cmd/dexc-desktop/app_darwin.go Outdated Show resolved Hide resolved

chappjc mentioned this pull request May 26, 2023

packaging: dexc-desktop packaging for Darwin #2333

Merged

chappjc reviewed May 26, 2023

View reviewed changes

client/cmd/dexc-desktop/app_darwin.go Outdated Show resolved Hide resolved

martonp reviewed May 28, 2023

View reviewed changes

client/cmd/dexc-desktop/app_darwin.go Outdated Show resolved Hide resolved

client/cmd/dexc-desktop/app_darwin.go Outdated Show resolved Hide resolved

client/cmd/dexc-desktop/app_darwin.go Show resolved Hide resolved

client/cmd/dexc-desktop/app_darwin.go Outdated Show resolved Hide resolved

chappjc reviewed May 30, 2023

View reviewed changes

client/cmd/dexc-desktop/app_darwin.go Outdated Show resolved Hide resolved

ukane-philemon force-pushed the macos-app branch from 4682294 to 44db571 Compare June 1, 2023 18:54

ukane-philemon force-pushed the macos-app branch from 23c3db4 to 0d63738 Compare June 2, 2023 06:10

buck54321 requested changes Jun 9, 2023

View reviewed changes

ukane-philemon force-pushed the macos-app branch from 4ecd799 to b05889f Compare June 10, 2023 11:20

chappjc requested review from chappjc, martonp and buck54321 June 21, 2023 01:20

buck54321 requested changes Jun 23, 2023

View reviewed changes

ukane-philemon added 5 commits July 8, 2023 00:30

use macdrive Go library instead of webview

bdab0c3

Signed-off-by: Philemon Ukane <[email protected]>

go mod tidy

92c2517

Signed-off-by: Philemon Ukane <[email protected]>

dexc-desktop/app.darwin.go: refactor and add more features

8bfd46a

- Add support for upto 5 windows for macOS. - Add icon to system status bar. - Add more webview config preferences. - Refactor. Signed-off-by: Philemon Ukane <[email protected]>

review changes and refactor

8a8edf6

- Handle defer statements properly for darwin. - Remove syncserver for darwin - Refactor - Prevent multiple dexc-desktop instance. Signed-off-by: Philemon Ukane <[email protected]>

implement main menu bar and refactor

813f91d

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon added 5 commits July 8, 2023 00:30

implement simple lock for dexc-state-file

5ae2bee

Signed-off-by: Philemon Ukane <[email protected]>

dexc-desktop: refactor macOS app window creation

bd5b21c

Signed-off-by: Philemon Ukane <[email protected]>

wrap errors and minor cleanup

fa88e62

ignore webview refresh

4d1e3e6

Signed-off-by: Philemon Ukane <[email protected]>

buck's review changes

2713440

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon force-pushed the macos-app branch from b05889f to 2713440 Compare July 7, 2023 23:34

import pkg for non-darwin dexc-desktop app

055784a

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon mentioned this pull request Jul 10, 2023

Help Wanted: Implementing webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler: and using NSOpenPanel in Go progrium/darwinkit#137

Closed

ukane-philemon added 4 commits July 15, 2023 17:30

implement methods to handler file uploads and external links

3f1052d

Signed-off-by: Philemon Ukane <[email protected]>

bucks review changes

7d59e52

Signed-off-by: Philemon Ukane <[email protected]>

dexc-desktop: refactor dexc-desktop/app_darwin.go

3ec4aa5

Signed-off-by: Philemon Ukane <[email protected]>

dexc-desktop: move C code from main.go to app.go

be31187

Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon added 2 commits July 15, 2023 22:50

support MacOS navigation gestures

4e43a7c

Signed-off-by: Philemon Ukane <[email protected]>

dexc-desktop/app_darwin.go: default to web tls

d161e66

- Implement self-signed cert challenge handler for MacOS app Signed-off-by: Philemon Ukane <[email protected]>

ukane-philemon force-pushed the macos-app branch from d53fd37 to d161e66 Compare July 15, 2023 22:37

buck54321 reviewed Jul 17, 2023

View reviewed changes

buck54321 approved these changes Jul 17, 2023

View reviewed changes

buck54321 merged commit 3dd6adf into decred:master Jul 17, 2023
5 checks passed

buck54321 mentioned this pull request Aug 20, 2024

bisonw-desktop: don't force tls for mac os desktop app #2923

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dexc-desktop: Use macdrive for Darwin #2372

dexc-desktop: Use macdrive for Darwin #2372

ukane-philemon commented May 25, 2023 •

edited

Loading

ukane-philemon commented May 27, 2023

martonp left a comment

martonp commented May 28, 2023

ukane-philemon commented May 28, 2023 •

edited

Loading

ukane-philemon commented May 31, 2023

ukane-philemon commented Jun 1, 2023

martonp commented Jun 3, 2023

ukane-philemon commented Jun 3, 2023

buck54321 left a comment

ukane-philemon commented Jun 10, 2023

ukane-philemon commented Jun 10, 2023

buck54321 left a comment

ukane-philemon commented Jun 23, 2023

martonp commented Jun 24, 2023

ukane-philemon commented Jun 25, 2023

ukane-philemon commented Jul 7, 2023

chappjc commented Jul 10, 2023

ukane-philemon commented Jul 10, 2023

chappjc commented Jul 10, 2023

ukane-philemon commented Jul 10, 2023

ukane-philemon commented Jul 15, 2023 •

edited

Loading

buck54321 left a comment

ukane-philemon commented Jul 17, 2023 •

edited

Loading

ukane-philemon commented Jul 17, 2023 •

edited

Loading

dexc-desktop: Use macdrive for Darwin #2372

dexc-desktop: Use macdrive for Darwin #2372

Conversation

ukane-philemon commented May 25, 2023 • edited Loading

ukane-philemon commented May 27, 2023

martonp left a comment

Choose a reason for hiding this comment

martonp commented May 28, 2023

ukane-philemon commented May 28, 2023 • edited Loading

ukane-philemon commented May 31, 2023

ukane-philemon commented Jun 1, 2023

martonp commented Jun 3, 2023

ukane-philemon commented Jun 3, 2023

buck54321 left a comment

Choose a reason for hiding this comment

ukane-philemon commented Jun 10, 2023

ukane-philemon commented Jun 10, 2023

buck54321 left a comment

Choose a reason for hiding this comment

ukane-philemon commented Jun 23, 2023

martonp commented Jun 24, 2023

ukane-philemon commented Jun 25, 2023

ukane-philemon commented Jul 7, 2023

chappjc commented Jul 10, 2023

ukane-philemon commented Jul 10, 2023

chappjc commented Jul 10, 2023

ukane-philemon commented Jul 10, 2023

ukane-philemon commented Jul 15, 2023 • edited Loading

buck54321 left a comment

Choose a reason for hiding this comment

ukane-philemon commented Jul 17, 2023 • edited Loading

ukane-philemon commented Jul 17, 2023 • edited Loading

ukane-philemon commented May 25, 2023 •

edited

Loading

ukane-philemon commented May 28, 2023 •

edited

Loading

ukane-philemon commented Jul 15, 2023 •

edited

Loading

ukane-philemon commented Jul 17, 2023 •

edited

Loading

ukane-philemon commented Jul 17, 2023 •

edited

Loading