client/dcr: Add rpc staking. #2316
Conversation
JoeGruffins
force-pushed
the
addharnessstaking
branch
from
71ce084
to
c8d7ff4
Compare
JoeGruffins
force-pushed
the
addharnessstaking
branch
4 times, most recently
from
e8a76ec
to
25a52a4
Compare
JoeGruffins
force-pushed
the
addharnessstaking
branch
from
25a52a4
to
064af34
Compare
|
Make core methods asset neutral and cleaning up help messages https://github.com/decred/dcrdex/compare/25a52a4119c86738aeb58f9909da03fc79eefff9..064af34478e9098c95ea04f5dcf4c3cbc70316e0 |
JoeGruffins
force-pushed
the
addharnessstaking
branch
2 times, most recently
from
f4f9f02
to
a465c48
Compare
|
Added |
client/asset/dcr/rpcwallet.go
Outdated
| @@ -912,26 +912,36 @@ func (w *rpcWallet) Tickets(ctx context.Context) ([]*asset.Ticket, error) { | |||
| w.log.Errorf("GetTransaction error for ticket %s: %v", h, err) | |||
| continue | |||
| } | |||
| blkHash, err := chainhash.NewHashFromStr(tx.BlockHash) | |||
There was a problem hiding this comment.
How would this work for unmined tickets? Or are all tickets guaranteed to be included in a block?
There was a problem hiding this comment.
I believe it errors and I saw this while testing with a block hash of all zeros....
There was a problem hiding this comment.
Testing out on simnet, it seems vsp is only including mined tickets in the results. @buck54321 do we need confirming tickets for native wallets? Or we can ignore these here as well so they act the same. Probably we want the unconfirmed tickets in results...
There was a problem hiding this comment.
I saw that too, but I figured we could follow up since it's not particular to RPC staking.
There was a problem hiding this comment.
Will set unmined block heights to -1 here and leave a TODO in the vsp wallet logic.
JoeGruffins
force-pushed
the
addharnessstaking
branch
from
a465c48
to
ea84ec5
Compare
|
Fixed update balance logic and adding unmined tickets to rpc wallet stake status response. https://github.com/decred/dcrdex/compare/a465c48681aca261a21c62f62bf24575c9820227..ea84ec5eac9a56a29524596167db2d165a21b0c5 |
JoeGruffins
force-pushed
the
addharnessstaking
branch
from
ea84ec5
to
57879a0
Compare
|
isSPV -> isNative as pointed out by @itswisdomagain an rpcwallet can also be SPV https://github.com/decred/dcrdex/compare/ea84ec5eac9a56a29524596167db2d165a21b0c5..57879a0b1f780f9fad2834ee31f0ef5ba6f97a53 |
part of #2264
depends on #2290Adds a rpc consumer for ticket purchasing.