Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/server: Dumb down finding balance. #2020

Closed
wants to merge 2 commits into from

Conversation

JoeGruffins
Copy link
Member

eth/server: Dumb down finding balance.

eth/jwt: Add eth module check.

closes #2016

@JoeGruffins
Copy link
Member Author

Also ok to rewind the jwt endpoint. Just offering this up as another option.

@chappjc
Copy link
Member

chappjc commented Jan 2, 2023

Are we absolutely certain that specifying the apis via --http.api=... (and --ws.api=...) does not affect the apis provided on the authrpc interface as well? The Prysm docs seem to suggest so.

@chappjc
Copy link
Member

chappjc commented Jan 2, 2023

Seeking clarification from geth devs: ethereum/go-ethereum#26406

@JoeGruffins
Copy link
Member Author

Looks like #2023 is preferred, so closing.

// reason, so we'll have to use CallContext and copy the mimic the
// internal RPCTransaction type.
var txs map[string]map[string]*RPCTransaction
err = c.caller.CallContext(ctx, &txs, "txpool_contentFrom", addr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any publicly available (paid or not) RPC providers that have any methods from the txpool namespace available. I'm thinking we can have server identify which method to take on connect via the CheckAPIModules function you added, however I'm not seeing rpc_modules supported anywhere either! Perhaps using a third-party RPC provider with server is gonna be trickier than I'd like.

Copy link
Member Author

@JoeGruffins JoeGruffins Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when I tested the modules request itself was only available from geth.

Copy link
Member

@chappjc chappjc Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been stewing on this, and I think we should revive it with a mini project to support an RPC provider that does not provide txpool, but use the smart balance if it does.

The aim would then be to allow the operator to use a third party RPC provider that they trust, ideally with their account's own API key so rate limits aren't so prevalent.

This is going to be key to make testnet or just mainnet "testing" less of burden. At present, it's ridiculously difficult, time consuming, and expensive to get geth+prysm running on either network. We are currently blocked on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth/server: Problem getting balances.
2 participants